You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS KMS key used to encrypt the S3 bucket that holds ssh keys is now created with name_prefix instead of name to ensure uniqueness.
The module output - bastion_security_group - now exposes the full content of the aws_security_group.bastion_linux resource. You can still retrieve the id attribute but will need to define it specifically. EG. module.bastion.bastion_security_group.id.
Launch templates will now resolve the SSM Parameter for amzn2-ami-hvm-x86_64-gp2 and resolve the latest version when creating instances. You can read the AWS documentation on using parameter resolution in templates here.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Trivy will check the following folders:
terraform/environments/performance-hub
Running Trivy in terraform/environments/performance-hub
2024-10-15T00:15:43Z INFO [vulndb] Need to update DB
2024-10-15T00:15:43Z INFO [vulndb] Downloading vulnerability DB...
2024-10-15T00:15:43Z INFO [vulndb] Downloading artifact... repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-15T00:15:46Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-15T00:15:46Z INFO [vuln] Vulnerability scanning is enabled
2024-10-15T00:15:46Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-15T00:15:46Z INFO [misconfig] Need to update the built-in checks
2024-10-15T00:15:46Z INFO [misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [--------------------------------------------------------->] 100.00% ? p/s ?156.02 KiB / 156.02 KiB [-----------------------------------------------] 100.00% 8.58 MiB p/s 200ms2024-10-15T00:15:46Z INFO [secret] Secret scanning is enabled
2024-10-15T00:15:46Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-15T00:15:46Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-15T00:15:47Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-15T00:15:47Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T00:15:49Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T00:15:50Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.aws_s3_object.user_public_keys" value="cty.NilVal"
2024-10-15T00:15:50Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.data.aws_subnet.local_account" value="cty.NilVal"
2024-10-15T00:15:50Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.dynamic.tag" value="cty.NilVal"
2024-10-15T00:15:50Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.dynamic.tag" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.tag" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.ingress" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.tag" value="cty.NilVal"
2024-10-15T00:15:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.ingress" value="cty.NilVal"
2024-10-15T00:15:52Z INFO [terraform executor] Ignore finding rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.3.1/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=7b2b75c178f855d8c48d3bda4ac53df782288c02/main.tf:141-151"
2024-10-15T00:15:52Z INFO Number of language-specific files num=0
2024-10-15T00:15:52Z INFO Detected config files num=10
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
HIGH: Application load balancer is not set to drop invalid headers.
════════════════════════════════════════
Passing unknown or invalid headers through to the target poses a potential risk of compromise.
By setting drop_invalid_header_fields to true, anything that does not conform to well known, defined headers will be removed by the load balancer.
HIGH: Load balancer is exposed publicly.
════════════════════════════════════════
There are many scenarios in which you would want to expose a load balancer to the wider internet, but this check exists as a warning to prevent accidental exposure of internal assets. You should ensure that this resource should be exposed publicly.
CRITICAL: Listener for application load balancer does not use HTTPS.
════════════════════════════════════════
Plain HTTP is unencrypted and human-readable. This means that if a malicious actor was to eavesdrop on your connection, they would be able to see all of your data flowing back and forth.
You should use HTTPS, which is HTTP over an encrypted (TLS) connection, meaning eavesdroppers cannot read your traffic.
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
*****************************
Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version:0.9.1)
tflint will check the following folders:
terraform/environments/performance-hub
*****************************
Running tflint in terraform/environments/performance-hub
Excluding the following checks: terraform_unused_declarations
3issue(s) found:
Warning: Missing version constraint for provider "template" in `required_providers` (terraform_required_providers)
on terraform/environments/performance-hub/data.tf line 9:
9: data"template_file""task_definition" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_required_providers.md
Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on terraform/environments/performance-hub/data.tf line 26:26:storage_bucket="${aws_s3_bucket.upload_files.id}"
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_deprecated_interpolation.md
Warning: Missing version constraint for provider "random" in `required_providers` (terraform_required_providers)
on terraform/environments/performance-hub/secrets.tf line 5:5:resource"random_password""random_password" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_required_providers.mdtflint_exitcode=2
Trivy Scan Failed
Show Output
*****************************
Trivy will check the following folders:
terraform/environments/performance-hub
*****************************
Running Trivy in terraform/environments/performance-hub
2024-10-15T00:15:43Z INFO [vulndb] Need to update DB
2024-10-15T00:15:43Z INFO [vulndb] Downloading vulnerability DB...2024-10-15T00:15:43Z INFO [vulndb] Downloading artifact...repo="ghcr.io/aquasecurity/trivy-db:2"2024-10-15T00:15:46Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"2024-10-15T00:15:46Z INFO [vuln] Vulnerability scanning is enabled
2024-10-15T00:15:46Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-15T00:15:46Z INFO [misconfig] Need to update the built-in checks
2024-10-15T00:15:46Z INFO [misconfig] Downloading the built-in checks...156.02 KiB /156.02 KiB [--------------------------------------------------------->] 100.00%? p/s ?156.02 KiB /156.02 KiB [-----------------------------------------------] 100.00%8.58 MiB p/s 200ms2024-10-15T00:15:46Z INFO [secret] Secret scanning is enabled
2024-10-15T00:15:46Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-15T00:15:46Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection2024-10-15T00:15:47Z INFO [terraformscanner] Scanning root module file_path="."2024-10-15T00:15:47Z WARN [terraformparser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.module="root"variables="networking"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.transition"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.principals"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.condition"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.transition"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.principals"value="cty.NilVal"2024-10-15T00:15:49Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.condition"value="cty.NilVal"2024-10-15T00:15:50Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.aws_s3_object.user_public_keys"value="cty.NilVal"2024-10-15T00:15:50Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.data.aws_subnet.local_account"value="cty.NilVal"2024-10-15T00:15:50Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.dynamic.tag"value="cty.NilVal"2024-10-15T00:15:50Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.dynamic.tag"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.transition"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.principals"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.condition"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.transition"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.principals"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.condition"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.tag"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.ingress"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.tag"value="cty.NilVal"2024-10-15T00:15:51Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.ingress"value="cty.NilVal"2024-10-15T00:15:52Z INFO [terraformexecutor] Ignore finding rule="aws-s3-encryption-customer-key"range="github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.3.1/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=7b2b75c178f855d8c48d3bda4ac53df782288c02/main.tf:141-151"2024-10-15T00:15:52Z INFO Number of language-specific files num=02024-10-15T00:15:52Z INFO Detected config files num=10
database.tf (terraform)
=======================
Tests:4 (SUCCESSES:0, FAILURES:4, EXCEPTIONS:0)
Failures:4 (HIGH:4, CRITICAL:0)
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
See https://avd.aquasec.com/misconfig/avd-aws-0086
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
See https://avd.aquasec.com/misconfig/avd-aws-0087
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
See https://avd.aquasec.com/misconfig/avd-aws-0091
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
See https://avd.aquasec.com/misconfig/avd-aws-0093
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
loadbalancer.tf (terraform)
===========================
Tests:4 (SUCCESSES:0, FAILURES:3, EXCEPTIONS:1)
Failures:3 (HIGH:2, CRITICAL:1)
HIGH: Application load balancer is not set to drop invalid headers.
════════════════════════════════════════
Passing unknown or invalid headers through to the target poses a potential risk of compromise.
By setting drop_invalid_header_fields to true, anything that does not conform to well known, defined headers will be removed by the load balancer.
See https://avd.aquasec.com/misconfig/avd-aws-0052
────────────────────────────────────────
loadbalancer.tf:5-25
────────────────────────────────────────
5 ┌ resource"aws_lb""external" {
6 │ #checkov:skip=CKV_AWS_917 │ #checkov:skip=CKV_AWS_1318 │ #checkov:skip=CKV2_AWS_209 │ #checkov:skip=CKV2_AWS_2810 │ name="${local.application_name}-loadbalancer"11 │ load_balancer_type="application"12 │ subnets=data.aws_subnets.shared-public.ids13 └ enable_deletion_protection=true..
────────────────────────────────────────
HIGH: Load balancer is exposed publicly.
════════════════════════════════════════
There are many scenarios in which you would want to expose a load balancer to the wider internet, but this check exists as a warning to prevent accidental exposure of internal assets. You should ensure that this resource should be exposed publicly.
See https://avd.aquasec.com/misconfig/avd-aws-0053
────────────────────────────────────────
loadbalancer.tf:5-25
────────────────────────────────────────
5 ┌ resource"aws_lb""external" {
6 │ #checkov:skip=CKV_AWS_917 │ #checkov:skip=CKV_AWS_1318 │ #checkov:skip=CKV2_AWS_209 │ #checkov:skip=CKV2_AWS_2810 │ name="${local.application_name}-loadbalancer"11 │ load_balancer_type="application"12 │ subnets=data.aws_subnets.shared-public.ids13 └ enable_deletion_protection=true..
────────────────────────────────────────
CRITICAL: Listener for application load balancer does not use HTTPS.
════════════════════════════════════════
Plain HTTP is unencrypted and human-readable. This means that if a malicious actor was to eavesdrop on your connection, they would be able to see all of your data flowing back and forth.
You should use HTTPS, which is HTTP over an encrypted (TLS) connection, meaning eavesdroppers cannot read your traffic.
See https://avd.aquasec.com/misconfig/avd-aws-0054
────────────────────────────────────────
loadbalancer.tf:58-69
────────────────────────────────────────
58 ┌ resource"aws_lb_listener""listener" {
59 │ #checkov:skip=CKV_AWS_260 │ #checkov:skip=CKV_AWS_10361 │ load_balancer_arn=aws_lb.external.id62 │ port=local.app_data.accounts[local.environment].server_port63 │ protocol="HTTP"64 │
65 │ default_action {
66 └ target_group_arn=aws_lb_target_group.target_group.id..
────────────────────────────────────────
monitoring.tf (terraform)
=========================
Tests:1 (SUCCESSES:0, FAILURES:1, EXCEPTIONS:0)
Failures:1 (HIGH:1, CRITICAL:0)
HIGH: Topic does not have encryption enabled.
════════════════════════════════════════
Topics should be encrypted to protect their contents.
See https://avd.aquasec.com/misconfig/avd-aws-0095
────────────────────────────────────────
monitoring.tf:21-23
────────────────────────────────────────
21 ┌ resource"aws_sns_topic""ddos_alarm" {
22 │ name="ddos_alarm"23 └ }
────────────────────────────────────────
s3.tf (terraform)
=================
Tests:4 (SUCCESSES:0, FAILURES:4, EXCEPTIONS:0)
Failures:4 (HIGH:4, CRITICAL:0)
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
See https://avd.aquasec.com/misconfig/avd-aws-0086
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
See https://avd.aquasec.com/misconfig/avd-aws-0087
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
See https://avd.aquasec.com/misconfig/avd-aws-0091
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
See https://avd.aquasec.com/misconfig/avd-aws-0093
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
trivy_exitcode=1
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Trivy will check the following folders:
terraform/environments/performance-hub
Running Trivy in terraform/environments/performance-hub
2024-10-15T11:15:30Z INFO [vulndb] Need to update DB
2024-10-15T11:15:30Z INFO [vulndb] Downloading vulnerability DB...
2024-10-15T11:15:30Z INFO [vulndb] Downloading artifact... repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-15T11:15:32Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-15T11:15:32Z INFO [vuln] Vulnerability scanning is enabled
2024-10-15T11:15:32Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-15T11:15:32Z INFO [misconfig] Need to update the built-in checks
2024-10-15T11:15:32Z INFO [misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-10-15T11:15:32Z INFO [secret] Secret scanning is enabled
2024-10-15T11:15:32Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-15T11:15:32Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-15T11:15:33Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-15T11:15:33Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.ap_landing_bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.aws_s3_object.user_public_keys" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.data.aws_subnet.local_account" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.dynamic.tag" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.dynamic.tag" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.bastion_linux.module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.tag" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.ingress" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.tag" value="cty.NilVal"
2024-10-15T11:15:35Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.windows-new-ecs.dynamic.ingress" value="cty.NilVal"
2024-10-15T11:15:36Z INFO [terraform executor] Ignore finding rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.3.1/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=7b2b75c178f855d8c48d3bda4ac53df782288c02/main.tf:141-151"
2024-10-15T11:15:37Z INFO Number of language-specific files num=0
2024-10-15T11:15:37Z INFO Detected config files num=10
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
HIGH: Application load balancer is not set to drop invalid headers.
════════════════════════════════════════
Passing unknown or invalid headers through to the target poses a potential risk of compromise.
By setting drop_invalid_header_fields to true, anything that does not conform to well known, defined headers will be removed by the load balancer.
HIGH: Load balancer is exposed publicly.
════════════════════════════════════════
There are many scenarios in which you would want to expose a load balancer to the wider internet, but this check exists as a warning to prevent accidental exposure of internal assets. You should ensure that this resource should be exposed publicly.
CRITICAL: Listener for application load balancer does not use HTTPS.
════════════════════════════════════════
Plain HTTP is unencrypted and human-readable. This means that if a malicious actor was to eavesdrop on your connection, they would be able to see all of your data flowing back and forth.
You should use HTTPS, which is HTTP over an encrypted (TLS) connection, meaning eavesdroppers cannot read your traffic.
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
*****************************
Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version:0.9.1)
tflint will check the following folders:
terraform/environments/performance-hub
*****************************
Running tflint in terraform/environments/performance-hub
Excluding the following checks: terraform_unused_declarations
3issue(s) found:
Warning: Missing version constraint for provider "template" in `required_providers` (terraform_required_providers)
on terraform/environments/performance-hub/data.tf line 9:
9: data"template_file""task_definition" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_required_providers.md
Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)
on terraform/environments/performance-hub/data.tf line 26:26:storage_bucket="${aws_s3_bucket.upload_files.id}"
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_deprecated_interpolation.md
Warning: Missing version constraint for provider "random" in `required_providers` (terraform_required_providers)
on terraform/environments/performance-hub/secrets.tf line 5:5:resource"random_password""random_password" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_required_providers.mdtflint_exitcode=2
Trivy Scan Failed
Show Output
*****************************
Trivy will check the following folders:
terraform/environments/performance-hub
*****************************
Running Trivy in terraform/environments/performance-hub
2024-10-15T11:15:30Z INFO [vulndb] Need to update DB
2024-10-15T11:15:30Z INFO [vulndb] Downloading vulnerability DB...2024-10-15T11:15:30Z INFO [vulndb] Downloading artifact...repo="ghcr.io/aquasecurity/trivy-db:2"2024-10-15T11:15:32Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"2024-10-15T11:15:32Z INFO [vuln] Vulnerability scanning is enabled
2024-10-15T11:15:32Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-15T11:15:32Z INFO [misconfig] Need to update the built-in checks
2024-10-15T11:15:32Z INFO [misconfig] Downloading the built-in checks...156.02 KiB /156.02 KiB [------------------------------------------------------] 100.00%? p/s 100ms2024-10-15T11:15:32Z INFO [secret] Secret scanning is enabled
2024-10-15T11:15:32Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-15T11:15:32Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection2024-10-15T11:15:33Z INFO [terraformscanner] Scanning root module file_path="."2024-10-15T11:15:33Z WARN [terraformparser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.module="root"variables="networking"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.principals"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.condition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.principals"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.ap_landing_bucket.dynamic.condition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.aws_s3_object.user_public_keys"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.data.aws_subnet.local_account"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.dynamic.tag"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.dynamic.tag"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.principals"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.condition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_expiration"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.noncurrent_version_transition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.principals"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.bastion_linux.module.s3-bucket.dynamic.condition"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.tag"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.ingress"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.tag"value="cty.NilVal"2024-10-15T11:15:35Z ERROR [terraformevaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.block="module.windows-new-ecs.dynamic.ingress"value="cty.NilVal"2024-10-15T11:15:36Z INFO [terraformexecutor] Ignore finding rule="aws-s3-encryption-customer-key"range="github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.3.1/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=7b2b75c178f855d8c48d3bda4ac53df782288c02/main.tf:141-151"2024-10-15T11:15:37Z INFO Number of language-specific files num=02024-10-15T11:15:37Z INFO Detected config files num=10
database.tf (terraform)
=======================
Tests:4 (SUCCESSES:0, FAILURES:4, EXCEPTIONS:0)
Failures:4 (HIGH:4, CRITICAL:0)
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
See https://avd.aquasec.com/misconfig/avd-aws-0086
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
See https://avd.aquasec.com/misconfig/avd-aws-0087
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
See https://avd.aquasec.com/misconfig/avd-aws-0091
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
See https://avd.aquasec.com/misconfig/avd-aws-0093
────────────────────────────────────────
database.tf:171-187
────────────────────────────────────────
171 ┌ resource"aws_s3_bucket""database_backup_files" {
172 │ #checkov:skip=CKV_AWS_18173 │ #checkov:skip=CKV_AWS_144174 │ #checkov:skip=CKV2_AWS_6175 │ bucket="${local.application_name}-db-backups-${local.environment}"176 │
177 │ lifecycle {
178 │ prevent_destroy=true179 └ }
...
────────────────────────────────────────
loadbalancer.tf (terraform)
===========================
Tests:4 (SUCCESSES:0, FAILURES:3, EXCEPTIONS:1)
Failures:3 (HIGH:2, CRITICAL:1)
HIGH: Application load balancer is not set to drop invalid headers.
════════════════════════════════════════
Passing unknown or invalid headers through to the target poses a potential risk of compromise.
By setting drop_invalid_header_fields to true, anything that does not conform to well known, defined headers will be removed by the load balancer.
See https://avd.aquasec.com/misconfig/avd-aws-0052
────────────────────────────────────────
loadbalancer.tf:5-25
────────────────────────────────────────
5 ┌ resource"aws_lb""external" {
6 │ #checkov:skip=CKV_AWS_917 │ #checkov:skip=CKV_AWS_1318 │ #checkov:skip=CKV2_AWS_209 │ #checkov:skip=CKV2_AWS_2810 │ name="${local.application_name}-loadbalancer"11 │ load_balancer_type="application"12 │ subnets=data.aws_subnets.shared-public.ids13 └ enable_deletion_protection=true..
────────────────────────────────────────
HIGH: Load balancer is exposed publicly.
════════════════════════════════════════
There are many scenarios in which you would want to expose a load balancer to the wider internet, but this check exists as a warning to prevent accidental exposure of internal assets. You should ensure that this resource should be exposed publicly.
See https://avd.aquasec.com/misconfig/avd-aws-0053
────────────────────────────────────────
loadbalancer.tf:5-25
────────────────────────────────────────
5 ┌ resource"aws_lb""external" {
6 │ #checkov:skip=CKV_AWS_917 │ #checkov:skip=CKV_AWS_1318 │ #checkov:skip=CKV2_AWS_209 │ #checkov:skip=CKV2_AWS_2810 │ name="${local.application_name}-loadbalancer"11 │ load_balancer_type="application"12 │ subnets=data.aws_subnets.shared-public.ids13 └ enable_deletion_protection=true..
────────────────────────────────────────
CRITICAL: Listener for application load balancer does not use HTTPS.
════════════════════════════════════════
Plain HTTP is unencrypted and human-readable. This means that if a malicious actor was to eavesdrop on your connection, they would be able to see all of your data flowing back and forth.
You should use HTTPS, which is HTTP over an encrypted (TLS) connection, meaning eavesdroppers cannot read your traffic.
See https://avd.aquasec.com/misconfig/avd-aws-0054
────────────────────────────────────────
loadbalancer.tf:58-69
────────────────────────────────────────
58 ┌ resource"aws_lb_listener""listener" {
59 │ #checkov:skip=CKV_AWS_260 │ #checkov:skip=CKV_AWS_10361 │ load_balancer_arn=aws_lb.external.id62 │ port=local.app_data.accounts[local.environment].server_port63 │ protocol="HTTP"64 │
65 │ default_action {
66 └ target_group_arn=aws_lb_target_group.target_group.id..
────────────────────────────────────────
s3.tf (terraform)
=================
Tests:4 (SUCCESSES:0, FAILURES:4, EXCEPTIONS:0)
Failures:4 (HIGH:4, CRITICAL:0)
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.
See https://avd.aquasec.com/misconfig/avd-aws-0086
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.
See https://avd.aquasec.com/misconfig/avd-aws-0087
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.
See https://avd.aquasec.com/misconfig/avd-aws-0091
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.
See https://avd.aquasec.com/misconfig/avd-aws-0093
────────────────────────────────────────
s3.tf:7-23
────────────────────────────────────────
7 ┌ resource"aws_s3_bucket""upload_files" {
8 │ #checkov:skip=CKV_AWS_189 │ #checkov:skip=CKV_AWS_14410 │ #checkov:skip=CKV2_AWS_611 │ bucket="${local.application_name}-uploads-${local.environment}"12 │
13 │ lifecycle {
14 │ prevent_destroy=true15 └ }
..
────────────────────────────────────────
trivy_exitcode=1
dependenciesPull requests that update a dependency fileenvironments-repositoryUsed to exclude PRs from this repo in our Slack PR updateterraformPull requests that update Terraform code
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
github-actions
bot
added
the
environments-repository
Bumps bastion_linux::modernisation-platform-terraform-bastion-linux from 4.2.1 to 4.3.1.
Release notes
Sourced from bastion_linux::modernisation-platform-terraform-bastion-linux's releases.
Commits
ab924e5Merge pull request #571 from ministryofjustice/dependabot/github_actions/gith...0aeff36Bump github/codeql-action from 3.26.12 to 3.26.139a92439Merge pull request #569 from ministryofjustice/feature/7569-unit-tests4d638cbMerge pull request #570 from ministryofjustice/dependabot/github_actions/mini...0f844c3Update versions.tff820ed1Update terraform-static-analysis.ymlb8abd5cUpdate format-code.yml714055cBump ministryofjustice/github-actions from 18.2.2 to 18.2.489aaf2cadded checkov skip as policy is defined as a separate resource and not inline7d94ff1terraform-docs: automated actionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)