Poc ingest domain code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
reviewed
Mar 19, 2024
| with open(self.source_config.manifest_local_path, "r") as f: | ||
| manifest = json.load(f) | ||
| else: | ||
| # TODO: implement get from s3 |
There was a problem hiding this comment.
Can this raise NotImplementedError so if the config is set it doesn't fail silently?
MatMoore
approved these changes
Mar 19, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is a proof of concept for ingesting data domains from dbt/ the moj's create-a-derived-table service.
It can be run on either a local dbt manifest.json file or (subject to some further development) the manifest files generated by create-a-derived-table and stored in s3.
The ingestion into datahub can be run via the datahub cli with the
datahub ingest -c {path-to-recipe-yaml}command - which simply creates the domains as per the manifest within the pointed to datahub instance