Protect against get_content_id() raising an error #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minetest.get_content_id() can error out of the game in MT 5.2.0 if another mod (such as moreblocks) uses register_alias_force() on the node.
|
sfan5's fix has been merged into Minetest, and I have faith it will solve this, so the PR is no longer required with latest MT builds. |
|
@debagos I don't know whether it was the right decision, but
Those who go to github instead of contentdb could still get the fix version from this PR's source. e.g. https://github.com/Treer/nether/archive/bugfix/get_content_id.zip |
|
@Treer I didn't know that you created a fix already because i could see it anywhere. Thank you very much for the fix!
Maybe that's right, but between the release of 5.2 and the next release my server is (was) in an unplayable state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sfan5 submitted a fix, so this PR probably won't need to be merged. I'll close it when the fix is merged.
Implements @trungus's fix for issue #19: the minetest.get_content_id() problem in MT 5.2.0.
Whether this should be merged depends on whether Minetest devs decide to fix the behavior of get_content_id() when register_alias_force() is used.
Note that merging this fix isn't enough - someone would need to update the Content DB as well. Currently it's in PilzAdam's account.