Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Task AB#1268089) | Defer token store unlock until token refresh response action occurs #168

Commits on Jan 24, 2024

  1. Modify OAuth2 request middleware to delay token storage unlock until …

    …after new token stored or old token deleted
    
    Currently the token store unlock occurs directly after the token refresh call completes, but prior to the new token being stored or the old token being deleted.  In situations with a high volume of asynchronous calls occurring leading up to the token refresh flow initiating, a race condition can occur upon token store unlock whereby a subsequent token refresh call that was queued then immediately retrieves the previous refresh token from the unlocked token store before the new refresh token has had a chance to be written to the token store.
    The resulting token refresh API call attempt using a burnt/no longer valid refresh token results in a 400 level error (e.g. 'invalid_grant' ) from the OAuth2 identity server.
    brettwellmanmbo committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    28df404 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Moved individual endTokenRefresh's calls based on refresh outcome to …

    …shared call
    
    - Removed some `self` references
    - Added comment
    brettwellmanmbo committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    00b678a View commit details
    Browse the repository at this point in the history