Skip to content

Commit

Permalink
build(deps): supports elixir/erlang 1.15/25
Browse files Browse the repository at this point in the history
refactor test to be deterministic - not rely on map keys order changes
after OTP 25 to OTP 26
  • Loading branch information
grzuy committed Jul 23, 2024
1 parent 32ad63a commit 39c9ccf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
lint: true
- elixir: '1.16'
erlang: '26.2.5'
- elixir: '1.15'
erlang: '25.3.2.13'
steps:
- uses: actions/checkout@v4
- uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ defmodule TowerEmail.MixProject do
[
app: :tower_email,
version: "0.1.0",
elixir: "~> 1.16",
elixir: "~> 1.15",
start_permanent: Mix.env() == :prod,
deps: deps()
]
Expand Down
6 changes: 3 additions & 3 deletions test/tower_email_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ defmodule TowerEmailTest do
@tag capture_log: true
test "reports long match error" do
in_unlinked_process(fn ->
%{eleven: "eleven"} = %{
[eleven: "eleven"] = [

Check warning on line 36 in test/tower_email_test.exs

View workflow job for this annotation

GitHub Actions / main (1.15, 25.3.2.13)

this check/guard will always yield the same result

Check warning on line 36 in test/tower_email_test.exs

View workflow job for this annotation

GitHub Actions / main (1.15, 25.3.2.13)

this check/guard will always yield the same result
one: "one",
two: "two",
three: "three",
Expand All @@ -44,7 +44,7 @@ defmodule TowerEmailTest do
eight: "eight",
nine: "nine",
ten: "ten"
}
]
end)

# TODO: Support waiting on assert_email_sent with a timeout
Expand All @@ -54,7 +54,7 @@ defmodule TowerEmailTest do
:email,
%{
subject:
~s([tower_email][test] MatchError: no match of right hand side value: %{one: "one", two: "two", three: "three", four: "f...)
~s([tower_email][test] MatchError: no match of right hand side value: [one: "one", two: "two", three: "three", four: "fo...)
}
},
1_000
Expand Down

0 comments on commit 39c9ccf

Please sign in to comment.