feat: include original error in Tower.ReportEventError message

mimiquate · Sep 17, 2024 · bf82434 · bf82434
1 parent e695db2
commit bf82434
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/lib/tower.ex b/lib/tower.ex
@@ -211,10 +211,14 @@ defmodule Tower do
   """
 
   defmodule ReportEventError do
-    defexception [:original_exception, :reporter]
+    defexception [:original, :reporter]
 
-    def message(%__MODULE__{reporter: reporter}) do
-      "An error occurred while trying to report an event with reporter #{reporter}"
+    def message(%__MODULE__{reporter: reporter, original: {kind, reason, stacktrace}}) do
+      """
+      The following error occurred while trying to report an event with reporter #{reporter}:
+
+      #{Exception.format(kind, reason, stacktrace)}
+      """
     end
   end
 
@@ -446,7 +450,9 @@ defmodule Tower do
         reporter.report_event(event)
       rescue
         exception ->
-          raise ReportEventError, reporter: reporter, original_exception: exception
+          raise ReportEventError,
+            reporter: reporter,
+            original: {:error, exception, __STACKTRACE__}
       end
     end)
   end

diff --git a/test/tower_test.exs b/test/tower_test.exs
@@ -528,7 +528,7 @@ defmodule TowerTest do
           kind: :error,
           reason: %Tower.ReportEventError{
             reporter: BuggyReporter,
-            original_exception: %RuntimeError{message: "I have a bug"}
+            original: {:error, %RuntimeError{message: "I have a bug"}, [_ | _]}
           },
           stacktrace: stacktrace1
         },