Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500px: fallback when extended photo info missing #5035

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

patrickkfkan
Copy link

Currently, the 500px extractor first obtains photos through graphql endpoint, then it obtains extended data for the photos and possibly higher res versions with v1 API. However, if the v1 API response does not include data for a particular photo, that photo will be skipped from downloading. For example:

$ gallery-dl  "https://500px.com/p/aaronyu73/galleries/ellen"
[500px][warning] Unable to fetch photo 310889321
...

With this PR, instead of skipping the photo, the extractor fetches from the URL provided in the original graphql result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant