Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SwiftGodotMacros a dynamic library #142

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

tishin
Copy link
Contributor

@tishin tishin commented Sep 30, 2023

To match the existing linking behavior of the base library.

@migueldeicaza migueldeicaza merged commit f9f00d7 into migueldeicaza:main Sep 30, 2023
1 check passed
@migueldeicaza
Copy link
Owner

Thank you - this makes sense.

@tishin tishin deleted the dynamic-macros branch October 1, 2023 12:03
@migueldeicaza
Copy link
Owner

Mhm, this actually became through some side effect a dependency of SwiftGodot which is needed to run things.

I will likely have to undo this later today.

@tishin
Copy link
Contributor Author

tishin commented Oct 3, 2023

There's no side effect dependency. If you you use macros, you also need SwiftGodotMacros to run things. Which embeds SwiftGodot in itself, so the first of driver's dependencies in tutorials is redundant:

.target(
    name: "SimpleRunnerDriver",
    dependencies: [
        "SwiftGodot",
        .product(name: "SwiftGodotMacros", package: "SwiftGodot")
    ],

It will work with a single dependency on 'SwiftGodotMacros':

.target(
    name: "SimpleRunnerDriver",
    dependencies: [
        .product(name: "SwiftGodotMacros", package: "SwiftGodot"),
    ],

Because SwiftGodotMacros statically depends on SwiftGodot target and embeds it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants