Fix process argument limit error when building on Windows #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generated sources into a single file
|
Makes sense. One possible optimization for Windows would be to split the sharedPrinter from the printer, but pass a flag indicating that the generated output is being blended. And then concatenate the various outputs of printers at the end. The sole reason for that is that it significantly reduces the build time. Happy to merge in this way if you prefer. |
|
Thank you for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building SwiftGodot with full list of generated sources on Windows exceeds the 32K symbol limit of
CreateProcessresulting inerror: command Compiling Swift Module 'SwiftGodot' (899 sources) failed: unable to spawn process 'C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe' (The filename or extension is too long.)Merging all generated sources into a single file should fix the issue for now until it's resolved from the SPM side (or maybe modularization of sources in the project).