Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused variable key from examples #620

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Removed unused variable key from examples #620

merged 1 commit into from
Feb 27, 2024

Conversation

leopold-gravier
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Doc update? yes
BC breaks? no
Deprecations? no

Removed the unused variable key in some examples, which can be misleading.

@Rotzbua
Copy link
Collaborator

Rotzbua commented Feb 25, 2024

Thanks 👍
Your commit is from another account. Is this intended or do you want to update your commit?

@Rotzbua Rotzbua added the enhancement 🚀 a wish or proposal for future features label Feb 25, 2024
@leopold-gravier
Copy link
Contributor Author

Good point.
If you don't mind I'll amend the username tomorrow.

@leopold-gravier
Copy link
Contributor Author

I didn't manage to change the email address without messing too much with the git history. It will be fine to merge with the le78ld email.

@Rotzbua Rotzbua merged commit 7cd29b7 into miguelbalboa:master Feb 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement 🚀 a wish or proposal for future features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leopold-gravier @Rotzbua @le78ld