Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge v4 to mgt-chat #3026

Merged
merged 62 commits into from
Feb 7, 2024
Merged

chore: merge v4 to mgt-chat #3026

merged 62 commits into from
Feb 7, 2024

Conversation

gavinbarron
Copy link
Member

This merges the changes in main to the next/mgt-chat branch

gavinbarron and others added 30 commits November 14, 2023 06:26
…#2865)

adds method to clear selected item from teams channel picker elements
adds a story using selectionChanged event to show how clearSelectedItem can be uses
this ensures that keystrokes which might trigger in pages shortcuts in SharePoint don't reach those event listener and break the component experience
refactor the filtering of data for display inside a getter that filtered the fetched data based on the current state of the component
filtering happens on render now

Co-authored-by: Nickii Miaro <[email protected]>
add edit todo functionality
rewrite edit option to apply focus on input element, remove the fluent-checkbox wrapper on todo tasks, fix @keydown function, add Radio svg to fix incomplete checkbox
fix dot icon, fix title display
add edit date funtionality

---------

Co-authored-by: Gavin Barron <[email protected]>
Co-authored-by: Musale Martin <[email protected]>
renames component to better suit current usage
removes dead code calling deprecated Graph APIs for Outlook Tasks
moves a number of strings into the localizable string collection for the component
updates the generate script for mgt-react to clean files at the start of generation

BREAKING CHANGE: mgt-tasks has been removed and replaced with mgt-planner. mgt-planner does not support data-source switching to fetch data from the outlook tasks apis any longer.
Add custom avatar size tokens for components building from mgt-person
Add login person custom avatar-size token
Update css props in login, people and people-picker
Add default values to css tokens
Update JSDoc comments for person card with section css customization tokens
uses a post build script to rewrite the index.html file and inject a CSP meta tag
)

fix bug in changing mgt-person attributes

---------

Co-authored-by: Sébastien Levert <[email protected]>
fix: revert csp tag in developer index.html (#2910)
Promoting Search to GA
Updated stories for GA

---------

Co-authored-by: Gavin Barron <[email protected]>
allows the input to expand to show a larger placeholder
adds a story for the placeholder attribute
* feat: add ElectronContextBridgeProvider

* fix: missing export for ElectronContextBridgeProvider

---------

Co-authored-by: Gavin Barron <[email protected]>
Adds helpers to determine if current token has a required scope
Adds helper to calculate the minimum scope to be requested if necessary
Fix test for prepScopes to match new behavior

BREAKING CHANGE: prepScopes now accepts an array of scopes, this is checked against the set of currently consented scopes for the user. If any of the supplied scopes are found, then no additional scopes are requested. If no match is found then the user will be prompted to consent to the first scope in the supplied array of scopes

fix: getGroupImage now correctly requires group.read.all or group.readwrite.all

BREAKING CHANGE: applications using mgt-person with fetch-image and person-detal where the supplied value is a group will now need to consent to either Group.Read.All or Group.ReadWrite.All. This replaces the existing behavior where the group image would silently fail to load and show an http 403 error in the console

fix: updated todo and planner permissions

BREAKING CHANGE: minimal permission for planner calls changed from Group.ReadWrite.All to Tasks.ReadWrite for write operation and from Group.Read.All to Tasks.Read for read operations
updated the keydown for the people-picker behavior to ensure that tab and enter can be used to enter email addresses when the allow-any-email attribute is present
Updating overview table with latest components
Updating overview table
Linking to stories in overview
…2920)

Adding headers + count on requests when userFilters are present
* fix: remove readonly props from react components

React components were incorrectly exposing readonly properties as setable via Props
This change updates the generation script to correctly handle readonly properties
The generation script now handles empty propTypes and import collections
Empty prop types are not exported
removes the PersonViewType enum in favor of the ViewType enum

BREAKING CHANGE: PersonViewType has been removed. 'avatar' is no longer a valid value for the 'view' attribute on the 'mgt-person' component
also removes a couple of dead code paths and refactors for easier reading
adds alerts to make button click actions apparent in mgt-get refresh story

Closes #2349
Established pattern for using `@lit/tasks` in components with two new base classes; MgtBaseTaskComponent  and MgtTemplatedTaskComponent.
Converts existing component to use new base classes.
Deprecates the MgtBaseComponent and MgtTemplatedComponent  classes.
The dataChanged event from mgt-get now bubbles and is composed
MgtBaseTaskComponent supplies providerState as a reactive property in the default set of args to be watched
Fixes an error case in mgt-get where a there is no value template.

---------

Co-authored-by: Sébastien Levert <[email protected]>
sebastienlevert and others added 18 commits January 29, 2024 09:56
Update rollup and rollup config
move rollup config to .mjs file
fix ignore path for eslint

---------

Co-authored-by: Gavin Barron <[email protected]>
moves rollup configs to .mjs files
updates dependencies and configs for rollup
this will ensure that our v4 build can actually be published
* clean-up react-contoso homepage

* remove theme toggle

Co-authored-by: Sébastien Levert <[email protected]>

* remove theme toggle import

---------

Co-authored-by: Sébastien Levert <[email protected]>
Co-authored-by: Musale Martin <[email protected]>
adds extended tests for Localization on mgt-person
removes the initials property from the default set of strings for mgt-person
* Update the permissions for PR reporting

Add contents:read - allows reading commits of the pr
Add checks:write - reports the status of the job on the pr
Add id-token:write permission
set add button to disabled until task name is provided
fix planner localization string
@gavinbarron gavinbarron requested a review from a team as a code owner February 6, 2024 00:51
Copy link
Contributor

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

musale
musale previously approved these changes Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-chat.src.statefulClient 100% 100% 0
mgt-chat.src.utils 100% 86% 0
mgt-components.dist.es6.components.mgt-agenda.src.components.mgt-agenda 14% 100% 0
mgt-components.dist.es6.components.mgt-contact.src.components.mgt-contact 62% 100% 0
mgt-components.dist.es6.components.mgt-file-list.mgt-file-upload.src.components.mgt-file-list.mgt-file-upload 43% 100% 0
mgt-components.dist.es6.components.mgt-file-list.src.components.mgt-file-list 62% 100% 0
mgt-components.dist.es6.components.mgt-file.src.components.mgt-file 61% 100% 0
mgt-components.dist.es6.components.mgt-get.src.components.mgt-get 19% 100% 0
mgt-components.dist.es6.components.mgt-login.src.components.mgt-login 64% 100% 0
mgt-components.dist.es6.components.mgt-messages.src.components.mgt-messages 66% 100% 0
mgt-components.dist.es6.components.mgt-organization.src.components.mgt-organization 46% 100% 0
mgt-components.dist.es6.components.mgt-people-picker.src.components.mgt-people-picker 56% 100% 0
mgt-components.dist.es6.components.mgt-people.src.components.mgt-people 72% 100% 0
mgt-components.dist.es6.components.mgt-person-card.src.components.mgt-person-card 59% 33% 0
mgt-components.dist.es6.components.mgt-person.src.components.mgt-person 53% 100% 0
mgt-components.dist.es6.components.mgt-picker.src.components.mgt-picker 78% 100% 0
mgt-components.dist.es6.components.mgt-planner.src.components.mgt-planner 55% 100% 0
mgt-components.dist.es6.components.mgt-profile.src.components.mgt-profile 39% 100% 0
mgt-components.dist.es6.components.mgt-search-box.src.components.mgt-search-box 83% 100% 0
mgt-components.dist.es6.components.mgt-search-results.src.components.mgt-search-results 56% 100% 0
mgt-components.dist.es6.components.mgt-tasks-base.src.components.mgt-tasks-base 86% 100% 0
mgt-components.dist.es6.components.mgt-taxonomy-picker.src.components.mgt-taxonomy-picker 74% 100% 0
mgt-components.dist.es6.components.mgt-teams-channel-picker.src.components.mgt-teams-channel-picker 62% 100% 0
mgt-components.dist.es6.components.mgt-theme-toggle.src.components.mgt-theme-toggle 74% 100% 0
mgt-components.dist.es6.components.mgt-todo.src.components.mgt-todo 78% 100% 0
mgt-components.dist.es6.components.src.components 86% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-arrow-options.src.components.sub-components.mgt-arrow-options 76% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-dot-options.src.components.sub-components.mgt-dot-options 29% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-flyout.src.components.sub-components.mgt-flyout 40% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-spinner.src.components.sub-components.mgt-spinner 92% 100% 0
mgt-components.dist.es6.graph.src.graph 36% 100% 0
mgt-components.dist.es6.src 100% 100% 0
mgt-components.dist.es6.styles.src.styles 73% 100% 0
mgt-components.dist.es6.utils.src.utils 46% 100% 0
mgt-components.src.components 84% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 84% 76% 0
mgt-components.src.components.mgt-person-card 67% 48% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 40% 73% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 82% 46% 0
mgt-element.dist.es6.components.src.components 72% 74% 0
mgt-element.dist.es6.mock.src.mock 91% 77% 0
mgt-element.dist.es6.providers.src.providers 87% 83% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 73% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 60% (27955 / 46478) 70% (549 / 782) 0

@gavinbarron gavinbarron merged commit 188b1cb into next/mgt-chat Feb 7, 2024
10 checks passed
@gavinbarron gavinbarron deleted the merge/main-to-chat branch February 7, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants