add build dependency

microsoftgraph · May 7, 2024 · 9e28583 · 9e28583
1 parent cd8f8b5
commit 9e28583
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 10 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -75,13 +75,21 @@ jobs:
 
   # Configuration to run a SonarCloud analysis on main, release and next branches
   sonarcloud:
-    name: SonarCloud
+    name: SonarCloud Analysis
     runs-on: ubuntu-latest
+    needs: build
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout repository
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - uses: actions/download-artifact@v3
         with:
-          fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
-      - name: SonarCloud Scan
+          name: coverage-artifacts
+          path: coverage
+
+      - name: Run sonar cloud analysis
         uses: SonarSource/sonarcloud-github-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -43,13 +43,21 @@ jobs:
 
   # Configuration to run a SonarCloud analysis on main branch
   sonarcloud:
-    name: SonarCloud
+    name: SonarCloud Analysis
     runs-on: ubuntu-latest
+    needs: build
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout repository
+        uses: actions/checkout@v3
         with:
-          fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
-      - name: SonarCloud Scan
+          fetch-depth: 0
+
+      - uses: actions/download-artifact@v3
+        with:
+          name: coverage-artifacts
+          path: coverage
+
+      - name: Run sonar cloud analysis
         uses: SonarSource/sonarcloud-github-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -6,7 +6,7 @@ sonar.host.url=https://sonarcloud.io
 
 sonar.sources=packages
 sonar.test.inclusions=packages/**/*.tests.ts
-sonar.exclusions=node_modules, samples
+sonar.exclusions=node_modules
 sonar.sourceEncoding=UTF-8
 
-sonar.typescript.lcov.reportPaths=coverage/lcov.info
+sonar.javascript.lcov.reportPaths=coverage/lcov.info