Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clipboard support for image/webp #188

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BlackHC
Copy link
Contributor

@BlackHC BlackHC commented Dec 4, 2023

This requires using a canvas object to render the webp to png as image/webp is not supported (by Chromium at the very least).

Manually tested in Chrome 119.0.6045.199 (Official Build) (arm64).

BlackHC and others added 2 commits December 4, 2023 22:07
This requires using a canvas object to render the webp to png.

Manually tested in Chrome.
@vscodenpa vscodenpa added this to the December / January 2024 milestone Dec 14, 2023
@BlackHC
Copy link
Contributor Author

BlackHC commented Dec 15, 2023

Thank you so much for the approval.

  1. For the two failing checks - is there any information on why they failed? I don't have access to the Azure logs.

  2. I've been using this quite heavily, and there is a quirk I have found: when you click on copy, it takes a short amount of time to convert the webp to png for the clipboard blob. If the user clicks on the copy button and then immediately switches to a different window, the clipboard operation can fail with DOMException: Document is not focused. I don't think there is an easy fix.

I don't have the Javascript/VSCode knowledge to add a spinner or similar to the code, which might be a UX fix.

@joaomoreno joaomoreno removed this from the December / January 2024 milestone Feb 2, 2024
@DonJayamanne
Copy link
Contributor

Apologies for never getting back on this,
will get this sorted out this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants