[vcpkg scripts] use CMAKE_C_COMPILER_TARGET to detect cross-compilation #41651
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the only way to cross-compile using vcpkg_configure_make is to use a gcc cross toolchain with the target as the prefix. This is not how you cross compile with clang--with clang you set CMAKE_<LANG>_COMPILER_TARGET. This detects this from the toolchain file and passes it along
russelltg
force-pushed
the
configure_make_xcompile_clang
branch
2 times, most recently
from
cb6d1ed
to
316ac13
Compare
|
Don't expect changes to |
|
Not sure what you mean by "there is a triplet variable which I can already use" which variable are you referring to, and why would it be better than CMAKE_C_COMPILER_TARGET? Should I wait for that PR to land and update ports? |
|
The vcpkg owners don't want make changes to the unversioned script. Too much risk. So we have to wait for that PR. The variable is VCPKG_MAKE_BUILD_TRIPLET, I don't say it is better asking the compiler, but at least you can control which options are passed to |
JonLiu1993
added
the
category:tool-update
JonLiu1993
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to cross-compile using vcpkg_configure_make is
to use a gcc cross toolchain with the target as the prefix.
This is not how you cross compile with clang--with clang you set
CMAKE_<LANG>_COMPILER_TARGET. This detects this from the toolchain fileand passes it along.
This is tested & works with an internal toolchain file.
libbacktracefailed to cross-compile without this change.