Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[librtpi] include condition_variable.hpp fix #41601

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[librtpi] include condition_variable.hpp fix #41601

merged 1 commit into from
Oct 18, 2024

Conversation

rtzoeller
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@rtzoeller
Copy link
Contributor Author

This pulls in a header-only fix which has been merged upstream but not made it into an official release just yet.

@LilyWangLL LilyWangLL self-assigned this Oct 17, 2024
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Oct 17, 2024
@LilyWangLL
Copy link
Contributor

Thanks for your PR, we do not recommend using the method of updating to a commit to apply upstream fixes. Please use the patching method instead.

@LilyWangLL LilyWangLL marked this pull request as draft October 17, 2024 10:09
@rtzoeller
Copy link
Contributor Author

@LilyWangLL fixed!

@rtzoeller rtzoeller marked this pull request as ready for review October 17, 2024 13:06
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 18, 2024
@data-queue data-queue merged commit e99ecd9 into microsoft:master Oct 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@data-queue data-queue data-queue approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtzoeller @LilyWangLL @data-queue