Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bark] New port v0.3.0 #41570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikaellindemann
Copy link
Contributor

@mikaellindemann mikaellindemann commented Oct 15, 2024

bark is a modern, low latency datadog client for C++.

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

I opted to override windows shared library builds to be static, since the library does not yet produce the correct DLLs.

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 15, 2024
@BillyONeal
Copy link
Member

There was a networking mistake last night affecting all osx builds but there are unrelated failures here so I'm skipping rerunning that.

@mikaellindemann mikaellindemann force-pushed the port/bark-0.2.0 branch 3 times, most recently from 1d33e8b to 121e0c5 Compare October 17, 2024 08:48
@mikaellindemann mikaellindemann changed the title [bark] New port v0.2.0 [bark] New port v0.3.0 Oct 17, 2024
@mikaellindemann mikaellindemann force-pushed the port/bark-0.2.0 branch 2 times, most recently from 86e1585 to 57f6dfd Compare October 18, 2024 07:02
@mikaellindemann mikaellindemann marked this pull request as ready for review October 18, 2024 09:32
@mikaellindemann
Copy link
Contributor Author

There was a networking mistake last night affecting all osx builds but there are unrelated failures here so I'm skipping rerunning that.

It now compiles in CI on supported platforms.

ports/bark/portfile.cmake Outdated Show resolved Hide resolved
ports/bark/portfile.cmake Outdated Show resolved Hide resolved
ports/bark/usage Outdated Show resolved Hide resolved
ports/bark/vcpkg.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants