Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eventbus] Add new port #41563

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

motazmuhammad
Copy link

@motazmuhammad motazmuhammad commented Oct 14, 2024

Fixes##41549

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 changed the title Eventbus [eventbus] Add new port Oct 15, 2024
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 15, 2024
@BillyONeal
Copy link
Member

/azp run

@BillyONeal
Copy link
Member

Rerunning due to network mistake

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@motazmuhammad motazmuhammad marked this pull request as ready for review October 17, 2024 23:19
@motazmuhammad
Copy link
Author

@JonLiu1993 Now that all the test have passed, is the port ready for review? and/or approval?

@JonLiu1993
Copy link
Member

Tested usage successfully by eventbus:x64-windows:

eventbus provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(EventBus CONFIG REQUIRED)
  target_link_libraries(main PRIVATE Dexode::EventBus)

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The portfile fetches the wrong revision for the claimed version.

Comment on lines +5 to +10
# before this revision the build would fail on windows
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO gelldur/EventBus
REF 4689564c4c775456bfa0dfd976b4f48aca5f4d2a
SHA512 0f1f3c21d1c5a18da87e331f252cb464143ba2038a26e6edb6b11c9544c02dd1919fe728e803b382e8f6b89550582d7905170437c184f784cfa3f28c784a7e59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# before this revision the build would fail on windows
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO gelldur/EventBus
REF 4689564c4c775456bfa0dfd976b4f48aca5f4d2a
SHA512 0f1f3c21d1c5a18da87e331f252cb464143ba2038a26e6edb6b11c9544c02dd1919fe728e803b382e8f6b89550582d7905170437c184f784cfa3f28c784a7e59
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO gelldur/EventBus
REF v${VERSION}
SHA512 0 # please insert SHA512

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt the latest version would fail on windows there were some fixes added to address that in the commit referenced REF, and according to the maintainers guide, if a patch is in the upstream I should favor using it than patching the code myself, What should I do in this case?

To summarize, using v${VERSION} will fail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4689564c4c775456bfa0dfd976b4f48aca5f4d2a is older than, and included, in 3.1.2:
gelldur/EventBus@4689564

So this is just totally wrong. If the build fails with 3.1.2, check the actual error.

ports/eventbus/portfile.cmake Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@JonLiu1993 JonLiu1993 marked this pull request as draft October 18, 2024 06:08
apply suggested changes

Co-authored-by: Kai Pastor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants