Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asyncplusplus] Update asyncplusplus to v1.2 #41420

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JanWilczek
Copy link

This PR updates the port for Amanieu/asyncplusplus without changing the official version number.

The port is now based on commit 4159da7 from the upstream repository, which introduces an important update allowing the library to be used with C++ 20 and 23 without breaking the compatibility with previous C++ standards (std::aligned_storage and std::invoke_result, for example).

Since this is not an official version bump, I've incremented the port-version to reflect the change.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JanWilczek
Copy link
Author

@JonLiu1993 , this is the new PR to merge, sorry for the mess.

@JanWilczek JanWilczek marked this pull request as ready for review October 8, 2024 10:09
@dg0yt
Copy link
Contributor

dg0yt commented Oct 8, 2024

This PR makes the port lie about its version.
Amanieu/asyncplusplus@172ca3f...4159da7

@JavierMatosD
Copy link
Contributor

This PR updates the port for Amanieu/asyncplusplus without changing the official version number.

We can't update ports in this fashion. If the port claims to give you version 1.1, then it must provide version 1.1. We can't simply give them a newer version.

which introduces an important update allowing the library to be used with C++ 20 and 23 without breaking the compatibility with previous C++ standards

What are these changes, exactly? Is there a particular issue you are facing or is this a "nice to have"?

@JavierMatosD JavierMatosD marked this pull request as draft October 8, 2024 19:49
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Oct 9, 2024
@JanWilczek
Copy link
Author

JanWilczek commented Oct 9, 2024

We can't update ports in this fashion. If the port claims to give you version 1.1, then it must provide version 1.1. We can't simply give them a newer version.

How to otherwise update ports that did not have a new release, yet were updated to support the new standard?

What are these changes, exactly? Is there a particular issue you are facing or is this a "nice to have"?

Version 1.1 of this library is using std::result_of which was completely removed (not just deprecated) in C++ 20 in favor of std::invoke_result. So the library at the 1.1 release does not compile with C++ 20 (which my project is using). This was updated on master but without a new release. The library continues to support older standards though.

I have opened an issue on the library's GitHub to create a new release but the owner does not seem active there.

@JavierMatosD
Copy link
Contributor

We can't update ports in this fashion. If the port claims to give you version 1.1, then it must provide version 1.1. We can't simply give them a newer version.

How to otherwise update ports that did not have a new release, yet were updated to support the new standard?

What are these changes, exactly? Is there a particular issue you are facing or is this a "nice to have"?

Version 1.1 of this library is using std::result_of which was completely removed (not just deprecated) in C++ 20 in favor of std::invoke_result. So the library at the 1.1 release does not compile with C++ 20 (which my project is using). This was updated on master but without a new release. The library continues to support older standards though.

I have opened an issue on the library's GitHub to create a new release but the owner does not seem active there.

In that case, please download the fix directly from upstream and apply as a patch.

@JanWilczek
Copy link
Author

JanWilczek commented Oct 9, 2024 via email

@JavierMatosD
Copy link
Contributor

Thanks for the reply. If I cannot update the port in the vcpkg repo with this PR, I’ll simply keep the change in my fork of it. Thanks. From: Javier Matos Denizac Sent: Wednesday, October 9, 2024 9:51 PM To: microsoft/vcpkg @.> Cc: Jan Wilczek @.>; Author @.> Subject: Re: [microsoft/vcpkg] [asyncplusplus ] Update asyncplusplus to master (PR #41420) We can't update ports in this fashion. If the port claims to give you version 1.1, then it must provide version 1.1. We can't simply give them a newer version. How to otherwise update ports that did not have a new release, yet were updated to support the new standard? What are these changes, exactly? Is there a particular issue you are facing or is this a "nice to have"? Version 1.1 of this library is using std::result_of which was completely removed (not just deprecated) in C++ 20 in favor of std::invoke_result. So the library at the 1.1 release does not compile with C++ 20 (which my project is using). This was updated on master but without a new release. The library continues to support older standards though. I have opened an issue on the library's GitHub to create a new release but the owner does not seem active there. In that case, please download the fix directly from upstream and apply as a patch. — Reply to this email directly, view it on GitHub <#41420 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6TC4ZWVH27RVEKDXYRBX3Z2WCLHAVCNFSM6AAAAABPRXTSU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGMYTAOJTGM . You are receiving this because you authored the thread.Message ID: @.>

I want to clarify. I'm not saying we can't fix the issue. I'm stating that we can't change the ref to point to head or some arbitrary commit. I'm inviting you to download the commit that applies the fix you are seeking and applying that as a patch.

@LilyWangLL LilyWangLL changed the title [asyncplusplus ] Update asyncplusplus to master [asyncplusplus] Update asyncplusplus to master Oct 11, 2024
@JanWilczek
Copy link
Author

Thanks @JavierMatosD ; the maintainer of the library has tagged a new release so I can update the port properly 🙂

@JanWilczek JanWilczek changed the title [asyncplusplus] Update asyncplusplus to master [asyncplusplus] Update asyncplusplus to v1.2 Oct 17, 2024
@JanWilczek JanWilczek marked this pull request as ready for review October 18, 2024 07:42
@JanWilczek JanWilczek marked this pull request as draft October 18, 2024 07:45
@JanWilczek JanWilczek marked this pull request as ready for review October 21, 2024 05:44
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants