Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[steam-audio] Adding port #40942

Open
wants to merge 92 commits into
base: master
Choose a base branch
from
Open

Conversation

Honeybunch
Copy link
Contributor

@Honeybunch Honeybunch commented Sep 12, 2024

Adding this port for those of us who crave spatial audio

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Honeybunch Honeybunch marked this pull request as ready for review September 26, 2024 19:08
@Honeybunch
Copy link
Contributor Author

Friendly bump that this is ready for review 😃

ports/steam-audio/usage Outdated Show resolved Hide resolved
ports/steam-audio/use-vcpkg-deps.patch Outdated Show resolved Hide resolved
@@ -0,0 +1,7 @@
+@PACKAGE_INIT@
+
+include(CMakeFindDependencyMacro)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be used by find_dependency calls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of monkey see monkey do here from me. I was following the pattern that other packages like EASTL, bullet3 and others were doing. This is used as part of a .cmake.in file that's used to generate the dependency import routine IIRC. A bit of a weak spot here in my cmake knowledge though.

@JavierMatosD
Copy link
Contributor

@Honeybunch, please mark "ready for review" once you have responded to @FrankXie05 / @dg0yt review comments. Thanks!

@JavierMatosD JavierMatosD marked this pull request as draft October 8, 2024 21:34
@Honeybunch
Copy link
Contributor Author

I am trying to upstream what parts of this patch I can but the Steam-Audio repo hasn't seen activity for two months so it may take a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants