-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[steam-audio] Adding port #40942
base: master
Are you sure you want to change the base?
[steam-audio] Adding port #40942
Conversation
Co-authored-by: Kai Pastor <[email protected]>
…g them from debug/share
Friendly bump that this is ready for review 😃 |
@@ -0,0 +1,7 @@ | ||
+@PACKAGE_INIT@ | ||
+ | ||
+include(CMakeFindDependencyMacro) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be used by find_dependency
calls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of monkey see monkey do here from me. I was following the pattern that other packages like EASTL, bullet3 and others were doing. This is used as part of a .cmake.in file that's used to generate the dependency import routine IIRC. A bit of a weak spot here in my cmake knowledge though.
@Honeybunch, please mark "ready for review" once you have responded to @FrankXie05 / @dg0yt review comments. Thanks! |
I am trying to upstream what parts of this patch I can but the Steam-Audio repo hasn't seen activity for two months so it may take a while |
Adding this port for those of us who crave spatial audio
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.