Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zydis] Update version to v4.1.0 #39037

Merged
merged 11 commits into from
Jun 4, 2024
Merged

Conversation

FrankXie05
Copy link
Contributor

Fix #38691

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels May 30, 2024
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested suggestion.

Bonus question: Does the cmake config do find_dependency(zycore CONFIG)?

ports/zydis/zycore.patch Show resolved Hide resolved
ports/zydis/zycore.patch Outdated Show resolved Hide resolved
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Portfile bonus question:
What does

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")

remove, after

vcpkg_copy_tools(TOOL_NAMES ZydisDisasm ZydisInfo AUTO_CLEAN)

@dg0yt
Copy link
Contributor

dg0yt commented May 31, 2024

FrankXie05#7

@FrankXie05 FrankXie05 closed this May 31, 2024
@FrankXie05 FrankXie05 reopened this May 31, 2024
@dg0yt
Copy link
Contributor

dg0yt commented May 31, 2024

FrankXie05#7

FTR the idea of the patch there is that it might be upstreamed (when they do proper aliasing of targets in the zycore project).

@dg0yt
Copy link
Contributor

dg0yt commented Jun 1, 2024

FTR the idea of the patch there is that it might be upstreamed (when they do proper aliasing of targets in the zycore project).

zyantific/zycore-c#71
zyantific/zydis#508

@dg0yt
Copy link
Contributor

dg0yt commented Jun 2, 2024

With my PRs accepted upstream, https://github.com/zyantific/zydis/pull/508/files is what should be applied here.

@FrankXie05 FrankXie05 marked this pull request as ready for review June 3, 2024 05:56
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 3, 2024
@vicroms vicroms merged commit c4451fd into microsoft:master Jun 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zydis] update to 4.1.0
4 participants