Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_find_acquire_program(NINJA).cmake] Update to 1.11.1 #34750

Conversation

gerard-ryan-immersaview
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

I was getting some build discrepancies between my CI builds, which use this ninja, and my dev builds, which use the ninja that comes with Visual Studio which uses version 1.11.1.

I might not have the time to progress this from the draft stage if many ports need fixes, but we'll see.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 27, 2023

Implements #34433 (comment).

@Adela0814 Adela0814 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Oct 27, 2023
@gerard-ryan-immersaview gerard-ryan-immersaview marked this pull request as ready for review October 29, 2023 23:45
@gerard-ryan-immersaview
Copy link
Contributor Author

It looks like the CI succeeded so I imagine this should be fine.

Note: I came across additional discrepancies between my CI and Dev so this change may not be necessary to fix errors, but here all the same.

@Adela0814
Copy link
Contributor

Please fix the conflict and CI error.

@Adela0814
Copy link
Contributor

Please get failure logs here. Please ping me if you need any help.

@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@Adela0814 Adela0814 marked this pull request as draft January 8, 2024 09:21
@gerard-ryan-immersaview
Copy link
Contributor Author

Please get failure logs here. Please ping me if you need any help.

x64_android

Building tinyfiledialogs:[email protected]#4...
-- Fetching https://git.code.sf.net/p/tinyfiledialogs/code master...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /usr/bin/git fetch https://git.code.sf.net/p/tinyfiledialogs/code master -n
    Working Directory: /vcpkg/downloads/git-tmp
    Error code: 128
    See logs for more information:
      /mnt/vcpkg-ci/b/tinyfiledialogs/git-fetch-x64-android-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_git.cmake:86 (vcpkg_execute_required_process)
  ports/tinyfiledialogs/portfile.cmake:3 (vcpkg_from_git)
  scripts/ports.cmake:170 (include)


error: building tinyfiledialogs:x64-android failed with: BUILD_FAILED
Elapsed time to handle tinyfiledialogs:x64-android: 174 ms

arm64_android

Building tinyfiledialogs:[email protected]#4...
-- Fetching https://git.code.sf.net/p/tinyfiledialogs/code master...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /usr/bin/git fetch https://git.code.sf.net/p/tinyfiledialogs/code master -n
    Working Directory: /vcpkg/downloads/git-tmp
    Error code: 128
    See logs for more information:
      /mnt/vcpkg-ci/b/tinyfiledialogs/git-fetch-arm64-android-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_git.cmake:86 (vcpkg_execute_required_process)
  ports/tinyfiledialogs/portfile.cmake:3 (vcpkg_from_git)
  scripts/ports.cmake:170 (include)


error: building tinyfiledialogs:arm64-android failed with: BUILD_FAILED
Elapsed time to handle tinyfiledialogs:arm64-android: 196 ms

@Adela0814 These look like intermittent network failures to me, is there a way to re-run just those jobs?

@Adela0814
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gerard-ryan-immersaview gerard-ryan-immersaview marked this pull request as ready for review January 9, 2024 04:34
@Adela0814 Adela0814 removed their request for review January 9, 2024 06:49
@gerard-ryan-immersaview
Copy link
Contributor Author

It looks like the failures are due to Windows build machine timeouts.

@WangWeiLin-MV
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dg0yt
Copy link
Contributor

dg0yt commented May 1, 2024

1.12.0 seems to be more attractive:
https://github.com/ninja-build/ninja/releases/v1.12.0
#38494

@dg0yt
Copy link
Contributor

dg0yt commented May 3, 2024

1.12.0 seems to be more attractive: https://github.com/ninja-build/ninja/releases/v1.12.0 #38494

#38538

@BillyONeal
Copy link
Member

Hi there, thanks for the update. I'm closing this in favor of the other PR which updates to 1.12. (Which I also have to resurrect :) )

@BillyONeal BillyONeal closed this Jun 13, 2024
@gerard-ryan-immersaview gerard-ryan-immersaview deleted the update-ninja branch June 13, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants