Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curlpp] Change curl dependency to not include default features #32852

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

glorantq
Copy link
Contributor

@glorantq glorantq commented Jul 31, 2023

Fixes #32838 (one of the issues)

Having a dependency on default curl, this port pulls in features that might not be wanted by the users of the curl port. By depending on curl without default features instead, there are no unwanted features pulled in.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Successfully tested on arm64-osx

@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 31, 2023
@glorantq
Copy link
Contributor Author

@microsoft-github-policy-service agree

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Aug 1, 2023
@JavierMatosD JavierMatosD merged commit 41f42b3 into microsoft:master Aug 1, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[curl] Default features not getting disabled, using a specific SSL backend is basically impossible
3 participants