-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[protobuf] Fix protoc.exe use the new headers with old DLLs #32800
[protobuf] Fix protoc.exe use the new headers with old DLLs #32800
Conversation
I don't think this is the right solution. Please explain the problem further. |
@BillyONeal Should we show information about our internal testing to users? |
What new headers? What old DLLs? What does adding this definition fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be working around an MSVC++ compiler team infrastructure issue by changing downstream consumers.
Does this mean we need to keep these failures in the result of |
Yes. Compiler team needs to fix the infrastructure for their tests. |
Close this PR due to https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/494762. At present, this problem is avoided by modifying the code logic and macro And, this behavior will be the default in 17.9 and this issue will be completely resolved. |
Fix vcpkg testing MSVC issues.
According to the suggestion of Stephan, add compiler option
/D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR
to workaround this issue.SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.