Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] Fix protoc.exe use the new headers with old DLLs #32800

Closed

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented Jul 28, 2023

Fix vcpkg testing MSVC issues.

cmd.exe /C "cd /D D:\buildtrees\gamenetworkingsockets\x64-windows-dbg\src && D:\installed\x64-windows\tools\protobuf\protoc.exe 
--cpp_out D:/buildtrees/gamenetworkingsockets/x64-windows-dbg/src 
-I D:/buildtrees/gamenetworkingsockets/src/687597c3e9-05f1ecc051.clean/src/common D:/buildtrees/gamenetworkingsockets/src/687597c3e9-05f1ecc051.clean/src/common/steamnetworkingsockets_messages_certs.proto"
ninja: build stopped: subcommand failed.

According to the suggestion of Stephan, add compiler option /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR to workaround this issue.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 28, 2023
@Neumann-A
Copy link
Contributor

I don't think this is the right solution. Please explain the problem further.

@FrankXie05
Copy link
Contributor Author

@BillyONeal Should we show information about our internal testing to users?

@Osyotr
Copy link
Contributor

Osyotr commented Jul 28, 2023

What new headers? What old DLLs? What does adding this definition fix?

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be working around an MSVC++ compiler team infrastructure issue by changing downstream consumers.

@Cheney-W
Copy link
Contributor

Does this mean we need to keep these failures in the result of VCPKG Testing MSVC run until the MSVC++ compiler team infrastructure issue is fixed?

@Cheney-W Cheney-W changed the title [vcpkg baseline] Fix protoc.exe use the new headers with old DLLs [protobuf] Fix protoc.exe use the new headers with old DLLs Aug 3, 2023
@BillyONeal
Copy link
Member

Does this mean we need to keep these failures in the result of VCPKG Testing MSVC run until the MSVC++ compiler team infrastructure issue is fixed?

Yes. Compiler team needs to fix the infrastructure for their tests.

@FrankXie05
Copy link
Contributor Author

Close this PR due to https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/494762.

At present, this problem is avoided by modifying the code logic and macro _ENABLE_CONSTEXPR_MUTEX_CONSTRUCTOR.
Unless we actively pass the macro.

And, this behavior will be the default in 17.9 and this issue will be completely resolved.

@FrankXie05 FrankXie05 closed this Sep 8, 2023
@FrankXie05 FrankXie05 deleted the dev/Frank/protobuf_ci_unstable branch September 8, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants