-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skia] fix issue where vk_mem_alloc.h cannot find vulkan.h #32715
Conversation
@microsoft-github-policy-service agree |
After fixing the |
Sorry about that, this is my first PR. I think now these changes are correct. |
The following error message appears when testing the installation locally.
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
duplicate of #32740 |
I still think #32740 is overall a better solution, however in interest of getting this fixed quickly, I've reopened this as a stop-gap alternative. |
The other PR is ready as far as the fix is concerned. This PR will fail the same usage test: Using skia requires C++17. |
Ah I see, closing this again. Thank you. |
Fixes #32706