Update @typespec/migrate to work with updated semver package (#2202)

Fix #2195.
microsoft · Jul 21, 2023 · 8648c2e · 8648c2e
1 parent 7ac833a
commit 8648c2e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -143,8 +143,7 @@
       "program": "${workspaceFolder}/packages/migrate/dist/src/cli.js",
       "smartStep": true,
       "sourceMaps": true,
-      "skipFiles": ["<node_internals>/**/*.js"],
-      "cwd": "C:/Github/Sandbox/playground/cadl/migrate/0.37"
+      "skipFiles": ["<node_internals>/**/*.js"]
     },
     {
       "type": "node",

diff --git a/common/changes/@typespec/migrate/migrate-SemVerUpdate_2023-07-21-20-57.json b/common/changes/@typespec/migrate/migrate-SemVerUpdate_2023-07-21-20-57.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@typespec/migrate",
+      "comment": "Fix issue with latest semver package.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@typespec/migrate"
+}
diff --git a/packages/migrate/src/cli.ts b/packages/migrate/src/cli.ts
@@ -68,7 +68,12 @@ async function main() {
   console.log(`Current Typespec version ${cliOptions.tspVersion}.`);
   const stepKeys = Object.keys(migrationConfigurations);
   for (const key of stepKeys) {
-    if (semver.gt(key, cliOptions.tspVersion)) {
+    const compKey = semver.coerce(key);
+    if (compKey === null) {
+      console.log(`Invalid migration step version; could not be coerced: ${key}`);
+      process.exit(1);
+    }
+    if (semver.gt(compKey, cliOptions.tspVersion)) {
       console.log(
         `Migration step found to upgrade from ${cliOptions.tspVersion} to ${key}. Migrating...`
       );