Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add support for match_type value DefaultBranch #305 #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

esciara
Copy link

@esciara esciara commented Feb 17, 2021

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes. => They were no tests on match_type. No sure how tests can be added
  • All new and existing tests passed. => see above. please advise
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

see issue number.

Issue Number: #305

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

N/A

Other information

None

@ghost
Copy link

ghost commented Feb 17, 2021

CLA assistant check
All CLA requirements met.

@esciara esciara force-pushed the support-for-matchtype-defaultbranch branch from 6351efa to 39dcb95 Compare February 17, 2021 16:36
@esciara esciara changed the title feat: add support for match_type value DefaultBranch #305 WIP: feat: add support for match_type value DefaultBranch #305 Feb 18, 2021
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Feb 22, 2022

@esciara Can help resolve the conflict and add AccTests result for this enhancement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants