Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for appcenter service connections #209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paulbehrisch
Copy link

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • [x ] Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Added appcenter service connection support.
https://docs.microsoft.com/en-us/appcenter/distribution/vsts-deploy

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

This change adds support for app center service connections.

Usage:

resource "azuredevops_serviceendpoint_appcenter" "paul-ios" {
 project_id            = azuredevops_project.project.id
 service_endpoint_name = "foo-org-appcenter"
 description           = "appcenter connection for foo-org"
 apitoken              = "xxxxxxxxx"
}

I copied resource_serviceendpoint_bitbucket.go and modifed accordingly. I noticed that the Bitbucket service connection itself has no tests, and I'm myself not too sure how to write a test for it since it requires an additional service. Could you point me in the right direction?

@xuzhang3
Copy link
Collaborator

@paulbehrisch You can find the Bitbucket AccTest and Document here. Acceptance tests are in the internal/acceptancetests directory.

@tmeckel
Copy link
Contributor

tmeckel commented Dec 6, 2021

@paulbehrisch after the provider has been upgraded to the v6 API the code for service connections has to be changed. So it might be a better approach to finish the PR here before the upgrade is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants