Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource
azuredevops_service_principal_entitlement
#1028base: main
Are you sure you want to change the base?
New Resource
azuredevops_service_principal_entitlement
#1028Changes from 19 commits
769d6a1
73166e7
a832802
1c25382
8f878c9
29f937d
0097045
94fc5d7
4f3f26f
1e1dba7
f04abe4
89326f6
5142b16
ec9bfe9
772e91d
ac8f1f2
2c58d06
83bd8b9
de14ea5
85ba430
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should check the
servicePrincipalEntitlement.ServicePrincipal.Descriptor
andservicePrincipalEntitlement.ServicePrincipal
first before get the values to prevent potential nil exceptionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the request. The check is done in l126, before the function is called. I can repeat the same check within the function and throw an error if that is the correct way to do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service may not return the property due to permission. Therefore, you need to check this property before calling it with a pointer.