Allow for smaller share dialog when we don't want previews #9655
Conversation
| @@ -209,7 +207,7 @@ export class ShareEditor extends auth.Component<ShareEditorProps, ShareEditorSta | |||
| return visible | |||
| ? <Modal | |||
| title={lf("Share Project")} | |||
| className="sharedialog wide" | |||
| className={`sharedialog${thumbnails ? " wide" : ""}`} | |||
There was a problem hiding this comment.
Ahah, was my guesstimate of 40rem just the default when it's not .wide? Looks same
There was a problem hiding this comment.
Yep! I was a bit mind blown by that!
| @@ -195,9 +195,7 @@ export class ShareEditor extends auth.Component<ShareEditorProps, ShareEditorSta | |||
| const { visible, projectName: newProjectName, title, screenshotUri } = this.state; | |||
| const { simScreenshot, simGif } = pxt.appTarget.appTheme; | |||
| const hasIdentity = auth.hasIdentity() && this.isLoggedIn(); | |||
| const light = !!pxt.options.light; | |||
| const thumbnails = pxt.appTarget.cloud && pxt.appTarget.cloud.thumbnails | |||
There was a problem hiding this comment.
Was pxt.appTarget.cloud.thumbnails superfluous in some way? I don't really know what it represents, but was curious as to why it was removed.
There was a problem hiding this comment.
I'm not sure as to what it did, honestly. But the light and thumbnails variables were never used, and for the case of share dialog, if it's specified in pxtarget.json that we do or don't want the thumbnails, I think that's enough to either supply or ignore them.
There was a problem hiding this comment.
Ah, got it. I missed that it was unused before your change.
The new share dialog allows for the recording and screenshotting of the simulators in micro:bit and arcade, but we don't have something to easily preview in Minecraft at the moment. That means that the "record gif" or "take screenshot" area of the share dialog is not useful and is also buggy.
If one of our targets specifies that it doesn't want to record GIF previews or allow screenshots of a simulator in
pxtarget.json, we now get rid of that part of the share modal. When getting rid of the preview area of the share modal, the input for the project name was awkwardly long. So I've also updated the styling so that if we don't have something to preview for the project, we use a smaller share modal.Before
After
Closes https://github.com/microsoft/pxt-minecraft/issues/2317