simplify rotary encoder sample

microsoft · Jul 27, 2023 · 3f59e09 · 3f59e09
1 parent 8c5ba25
commit 3f59e09
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/tools/microbit-jukebox/rotaryencoder.ts b/tools/microbit-jukebox/rotaryencoder.ts
@@ -1,16 +1,11 @@
 machine.addClientFactory(jacdac.SRV_ROTARY_ENCODER, (devid, srvid, options) => {
+    const clicks = 12
     const client = new modules.RotaryEncoderClient(`${devid}:${srvid}`)
-    let currentPosition = client.position()
-    if (!currentPosition) currentPosition = 0
-    client.onPositionChanged(() => {
-        let clicks = client.clicksPerTurn()
-        clicks = clicks ? clicks : 24
-        const newPosition = client.position()
-        machine.microbit.emit(
-            currentPosition < newPosition ? machine.EVENT_A : machine.EVENT_B
-        )
-        currentPosition = newPosition
-        machine.plot(newPosition % clicks, clicks, options)
+    let currentPosition = 0
+    client.onPositionChanged(delta => {
+        machine.microbit.emit(delta > 0 ? machine.EVENT_A : machine.EVENT_B)
+        currentPosition += delta
+        machine.plot(currentPosition % clicks, clicks, options)
     })
     return client
 })