Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pxt 10 and some other changes #1052

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

THEb0nny
Copy link
Contributor

@THEb0nny THEb0nny commented Mar 19, 2024

After switching to pxt-core v10, fieldmotors break.
Related to this.

microsoft/pxt-microbit#5496
microsoft/pxt#9865

@THEb0nny
Copy link
Contributor Author

Fixed all fields field_motors, field_ports, field_brickbuttons, field_music except field_color. When choosing a color, the color does not change. There is no error in the console.

Replacing ports with images. field ports has been removed. Almost completely repeats the functionality.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Mar 20, 2024

Replacing field ports to images. field ports has been removed. Almost completely repeats the functionality.

All sensor blocks that used field_ports had to register this. I don’t know how it could have been done differently without repeating these lines.

this.fieldOptions.columns="4"
this.fieldOptions.width="300"

Accidentally added field_colors changes to this commit. He's not ready. There are no errors, but the color selection does not work.

Where did turnRatio come from?
The last change to field_colour removed the addition of className. It’s not clear for what reason, but I’m adding it myself now.
The new version of FieldColorNumber does not apply applyColour() inside the doValueUpdate_() method. Secondly, the applyColour() method was redesigned in the new version so that it no longer worked with this enum code.
@THEb0nny
Copy link
Contributor Author

The colorenum field has been fixed.

@THEb0nny
Copy link
Contributor Author

@jwunderl @riknoll can someone see all the changes?

It turned out that the buttons were wrong for some reason. The sorting of the data in options.data has changed for some reason.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 3, 2024

It turned out that the buttons were wrong for some reason. The sorting of the data in options.data has changed for some reason. You can watch the problem and the solution in the video.

2024-05-03_22-56-04.mp4

Additional changes that build on this.
microsoft#1035
I also wanted to filter by vendorID and productID, but then the selection window did not display anything. I don't know what's wrong.
As before, downloading via bluetooth works on my surface pro 6 with windows 11. Loading did not work on another computer in the robotics class with Windows 10. Perhaps this change will have a positive effect. I will check it.
timeOut is quite an interesting property and if it is used in js, then switching in the block will not be converted.
@THEb0nny THEb0nny changed the title Bump pxt 10 Bump pxt 10 and some other changes May 7, 2024
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 7, 2024

For blocks pause until ready and pause until stalled property timeOut is quite an interesting property and if it is used in js, then switching in the block will not be converted.

@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 7, 2024

The changes that were added to download via bluetooth did not give a good result. I checked on a computer where the download did not work on the previous version. There are also problems with this change. I tried a bunch of different options, and one case worked. The download worked in one of the cases. After that, I wanted to check again, rebooted the computer and started trying bluetooth booting again, but nothing worked.
But I will note that, as before, bluetooth booting worked for my surface pro 6.

On the computer in the classroom the following error pops up, which is not present on my home surface pro 6.
TypeError: Cannot set properties of undefined (setting 'onConnectionChanged')

I will try to solve this separately later.

@THEb0nny
Copy link
Contributor Author

Remove the fill for .collapsedEditorTools #downloadArea
image
image

If the light sensor is not active (it is not connected), then do not transfer the value to a new range. Otherwise, the value will be 100.
@THEb0nny
Copy link
Contributor Author

I made a commit in which I implemented changes for the analog sensor class aimed at supporting older sensors for NXT, which cannot be detected automatically. For example, some Hitechnic sensors.
Here is an example, I got the values from the sensor - https://github.com/THEb0nny/makecode-ev3-hitechnic-eopd-sensor/blob/master/hteopd.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant