Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken categories in pxtToolbox #1046

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

THEb0nny
Copy link
Contributor

@THEb0nny THEb0nny commented Feb 6, 2024

I created a fix for pxtToolbox which breaks when adding some extensions. This bug appeared during the first beta version. I have attached a video of how this happens.
I actually don't understand why this leads to such a bug and why my solution works.

But adding custom.ts solved the bug. I don't know why this happens either.

Another observation worth noting is that the extensions that come from github do not break the categories in pxtToolbox.

2024-02-07_00-24-41.mp4

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Feb 6, 2024

I tried moving the namespace attributes into my libraries and it worked. To be honest I don't know why this works.
But this doesn't work for namespace brick. I don't understand, it's not logical.
Namespace console is also in lib ev3, because the file is there, there is no bug for it.

2024-02-07_00-30-43.mp4

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Feb 7, 2024

I have corrected the Brick category as follows.
I noticed that the namespace brick is in the files of another core library. Accordingly, I thought that because of this the category was being redefined and breaking. I moved the category attributes to ns.ts of the core library. This solved the problem.

I also thought that maybe I should move the files with the namespace brick from the core to the ev3 library. But this breaks the build, even though I specified the dependencies.

2024-02-07_13-33-55.mp4

@THEb0nny
Copy link
Contributor Author

@jwunderl hi, can you see the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant