Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New approved repos lib #1041

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

THEb0nny
Copy link
Contributor

@THEb0nny THEb0nny commented Nov 3, 2023

Moved the addition of extensions to a separate PR.

targetconfig.json Outdated Show resolved Hide resolved
Co-authored-by: Joey Wunderlich <[email protected]>
@jwunderl
Copy link
Member

jwunderl commented Nov 3, 2023

As mentioned over here #1038 (comment) there'll be a few changes we need to add as approved:

  • needs icon; see icon.png in the https://github.com/microsoft/makecode-minecraft-music block
  • docs for blocks; see the code for how they're referenced / stored in docs/, and good to add a short description in readme since that'll show up as well
  • needs MIT license
  • We have been avoiding throwing things in subcategories as students often find them hard to identify / realize they have to click into Sensors for the category to show up; likely best to add it as a top level category just below HiTechnic. that's not a requirement though / just how we've been doing things.

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Nov 4, 2023

As mentioned over here #1038 (comment) there'll be a few changes we need to add as approved:

  • needs icon; see icon.png in the https://github.com/microsoft/makecode-minecraft-music block
  • docs for blocks; see the code for how they're referenced / stored in docs/, and good to add a short description in readme since that'll show up as well
  • needs MIT license
  • We have been avoiding throwing things in subcategories as students often find them hard to identify / realize they have to click into Sensors for the category to show up; likely best to add it as a top level category just below HiTechnic. that's not a requirement though / just how we've been doing things.

icon png I will add, I will add documentation, the mit license is already specified.

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Nov 23, 2023

@jwunderl I tried providing a link to help, like in the extension you provided. When you click on the help button on the block, nothing opens.
//% help=github:makecode-ev3-hitechnic-color-sensor-v2/docs/all

Just as I said before, I added an image, but it does not appear in the expansion cards.

@THEb0nny
Copy link
Contributor Author

I also implemented a structure following the example of a color sensor extension. I specified the files in pxt.json, but still nothing appears when I click on help.

image

@THEb0nny
Copy link
Contributor Author

@jwunderl look here please?

@jwunderl
Copy link
Member

jwunderl commented Feb 2, 2024

I also implemented a structure following the example of a color sensor extension. I specified the files in pxt.json, but still nothing appears when I click on help.

image

it looks like those paths are missing docs/ at the beginning (/reference/... => docs/reference/... in the files list), and it looks like the help paths are pointing as if they were built in docs -- here's an example from that minecraft ext repo showing the format for referencing your own extensions docs: https://github.com/microsoft/makecode-minecraft-music/blob/main/src/note.ts#L81

Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help still has some hooking up needed to fix re: other comment, but docs are there / will merge in for now~

@jwunderl jwunderl merged commit a590cc3 into microsoft:master Feb 2, 2024
2 checks passed
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Feb 2, 2024

@jwunderl thank you for your cooperation, I will try to fix all remaining problems.

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Feb 6, 2024

it looks like those paths are missing docs/ at the beginning (/reference/... => docs/reference/... in the files list), and it looks like the help paths are pointing as if they were built in docs -- here's an example from that minecraft ext repo showing the format for referencing your own extensions docs: https://github.com/microsoft/makecode-minecraft-music/blob/main/src/note.ts#L81

@jwunderl, I changed it, but the help does not open. If you get a chance, take a look...
https://github.com/THEb0nny/makecode-ev3-hitechnic-color-sensor-v2

@THEb0nny THEb0nny deleted the new-approved-repos-lib branch March 30, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants