Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pxt v9 #1030

Merged
merged 33 commits into from
Aug 30, 2023
Merged

Bump pxt v9 #1030

merged 33 commits into from
Aug 30, 2023

Conversation

THEb0nny
Copy link
Contributor

@THEb0nny THEb0nny commented Aug 6, 2023

Installed the latest version of pxt-core, pxt-common-common-packages.

Fieldeditors reworked to avoid build issues. Add search to pxtarget(workspaceSearch).

Take the added file \docs\static\loader.svg from microbit so that there are no problems during assembly. Will need to be redone. But I don't quite understand where it is used.

Removed the fix of the scrolling elements of the simulator, because. it is no longer required.

Fixed the background color of the toolbar on the add extension screen.

Added a picture of the Microsoft brand logo that is displayed on first launch. A bug was fixed where the brand logo and the project logo overlapped each other due to custom styles that were written for the ev3 project logo.

I'm seeing performance issues on my end after the big jump from pxt-core. I understand that these are problems on my part in wsl ubuntu. This makes it hard to work...

There is a problem that the automation extension has disappeared from the add extension window.

The high contrast feature works (didn't work before).

We raise the version of pxt-core, pxt-common-packages. Field changes. Add search to pxtarget (workspaceSearch). Add missing files.
Removing a temporary fix

microsoft@4017a8b
Restore common-modal-header color in add extension window.
microsoft/pxt#9605

Fix overlapping of the Microsoft brand logo and the project logo on the first boot.
Fix color editordropdown selection JS or Python. Fix alignment inside dropdown menu.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Aug 7, 2023

@jwunderl please see the changes.

Lego cube logo. I drew it myself.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Aug 8, 2023

The size of the loader.svg file turned out to be incorrect, it needs to be redone...

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Aug 8, 2023

I redrawn the cube, it is completely white in illustrator, the same dimensions of 52.7x52.7 are left everywhere, but for some reason here the github displays 150x150.

Added more options
@THEb0nny THEb0nny requested a review from jwunderl August 13, 2023 11:41
The python language is translated from experiments.
Hide the blocklySearchArea search field on the mobile version of the site.
blocklySearchArea expanding horizontally.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Aug 13, 2023

image
image

Expanded the search field of the block to fit the width of the categories, it looks better.

I also made sure that the search field is removed on mobile view, because. the field becomes very small in width and cannot be used. I looked at what is done in microbit like this.

Before that, it was not possible to set the icon font awesome, tick. the font has been reassigned to a different one from Lego.
@THEb0nny
Copy link
Contributor Author

image

A different font was installed instead of fontawsome, and therefore the icons for the categories did not work.

@THEb0nny
Copy link
Contributor Author

It turned out that it was icons that broke categories when adding storage, brodcast extensions.

image

For storage and automation.
Icon sizes in these fonts turned out to be different. Native icons turned out to be smaller than fontawsome. I scaled them, and reduced the overall font size for the icons in the category.
@THEb0nny
Copy link
Contributor Author

image
Icon sizes in these fonts turned out to be different. Native icons turned out to be smaller than fontawsome. I scaled them, and reduced the overall font size for the icons in the category.

Change the extension code. Fontawesome icon added.
Changed color for storage extension to be different from automation extension.
Macros for accessing buffer and string data for storage lib.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Aug 19, 2023

Due to the addition of the storage makecode extension, it starts to break.
The hex file is not available, please connect to internet and try again. No more hex build issue with extension.

Looking at the console, I understood and found how this error is solved.
microsoft/pxt-microbit#1941
https://github.com/microsoft/pxt-common-packages/pull/782/files
tinkertanker/pxt-oled-ssd1306#17

The storage-core.ts file has been cleaned up. Sorted and added default values.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Aug 19, 2023

I added the ability to change the separator for the CSV file, because I realized that, for example, MS Excel, depending on regional settings, could not be displayed correctly, so, in my region, a point with a comma (;) instead of a comma (,) is used in my region. The comma is used for separation in fractional numbers.

image
image

image

It is possible to change the csv file separator.
This reverts commit 60118ef.
Removed padding so category button is full height. Removed the commented out css code that displays the button borders.
Removed too much margin top.
@jwunderl jwunderl merged commit b4e5e15 into microsoft:master Aug 30, 2023
3 checks passed
@THEb0nny
Copy link
Contributor Author

@jwunderl thank you.

@THEb0nny THEb0nny deleted the bump-pxt-v9 branch August 31, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants