Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context menu #186

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix context menu #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d3ec4
Fix context menu for links and nodes
Apr 16, 2024
a21be16
Increment version
Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 3.4.2.0
* Fix context menu for links and nodes

## 3.4.1.0
* Fix npm vulnerabilities

## 3.4.0.0
* Change forward cycles links processing

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "powerbi-visuals-sankey",
"version": "3.4.1.0",
"version": "3.4.2.0",
"description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow. Use it to find major contributions to an overall flow.",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions pbiviz.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"visual": {
"name": "SankeyDiagram",
"displayName": "Sankey 3.4.1.0",
"displayName": "Sankey 3.4.2.0",
"guid": "sankey02300D1BE6F5427989F3DE31CCA9E0F32020",
"visualClassName": "SankeyDiagram",
"version": "3.4.1.0",
"version": "3.4.2.0",
"description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow. Use it to find major contributions to an overall flow.",
"supportUrl": "https://community.powerbi.com",
"gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-sankey"
Expand Down
4 changes: 2 additions & 2 deletions src/behavior.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class SankeyDiagramBehavior{
this.behaviorOptions.nodes.on("contextmenu", (event: PointerEvent, node: SankeyDiagramNode) => {
if (event) {
this.selectionManager.showContextMenu(
node,
node.selectionId,
{
x: event.clientX,
y: event.clientY
Expand Down Expand Up @@ -139,7 +139,7 @@ export class SankeyDiagramBehavior{
this.behaviorOptions.links.on("contextmenu", (event: PointerEvent, link: SankeyDiagramLink) => {
if (event) {
this.selectionManager.showContextMenu(
link,
link.selectionId,
{
x: event.clientX,
y: event.clientY
Expand Down
Loading