Added Keyboard Navigation

[s-ddavydenko]

What did you do?
Improved accessibility by adding keyboard navigation. Features added:

• keyboard navigation (feature)
  

• focus outline (styles)
  

• aria roles (aria-selected, aria-label, tabindex, listbox, option) on elements
  

Why did you do it this way?
The appropriate aria roles and labels make the visual more understandable to screen readers which makes the sankey chart viewable to blind users and more. Keyboard navigation allows these users to actually use the sankey chart.

Anything else I should know?
Updated dependencies and added unit tests

Screenshots
Before:

After:

[s-ddavydenko]

@microsoft-github-policy-service agree

[zBritva]

Could you add unit tests for the new feature?

[zBritva]

The screen reader output in not descriptive.
And outline is not prefect for this links example. Did you consider to use custom outline? (border or custom path element to highlight the current link)

[MulyukovAidar]

Please check if npm audit fix helps resolving audit issues (see npm audit). Also increase the visual version in pbiviz.json, package.json and add a release note in changelog.md

[FirzinatKhuzeev]

Add description with screenshots

[s-ddavydenko]

The screen reader output in not descriptive.
And outline is not prefect for this links example. Did you consider to use custom outline? (border or custom path element to highlight the current link)

@zBritva for now, this would be too difficult to implement

[s-ddavydenko]

Could you add unit tests for the new feature?

Added

[s-ddavydenko]

Please check if npm audit fix helps resolving audit issues (see npm audit). Also increase the visual version in pbiviz.json, package.json and add a release note in changelog.md

changed 4 packages, and audited 782 packages in 2s

109 packages are looking for funding
  run `npm fund` for details

# npm audit report

request  *
Severity: moderate
Server-Side Request Forgery in Request - https://github.com/advisories/GHSA-p8p7-x288-28g6
Depends on vulnerable versions of tough-cookie
No fix available
node_modules/request
  coveralls  *
  Depends on vulnerable versions of request
  node_modules/coveralls

tough-cookie  <4.1.3
Severity: moderate
tough-cookie Prototype Pollution vulnerability - https://github.com/advisories/GHSA-72xf-g2v4-qvf3
No fix available
node_modules/tough-cookie

3 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Ran npm audit fix, this was the output

[s-ddavydenko]

Add description with screenshots

added

[AleksSavelev]

Looks good to me, but please, resolve conflicts.

[FirzinatKhuzeev]

Looks good to me, but please, resolve conflicts.

done

[uve]

Return 4 digit version. It's mandatory for all CVs

[FirzinatKhuzeev]

done

[uve]

change to 3.2.0.0

[FirzinatKhuzeev]

fixed