fix mha for in the case that present kv is not consumed #21777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianleiwu
reviewed
Aug 16, 2024
tianleiwu
reviewed
Aug 16, 2024
tianleiwu
reviewed
Aug 16, 2024
| // since there is no buffer for it. | ||
| // We check by requesting the output and if not there we'll adjust context.outputCount | ||
| const presentKeyShape = [ | ||
| parameters.batchSize, |
There was a problem hiding this comment.
This shape only works for MHA and GQA.
Attention output 1 shape is [2, B, N, T, H] instead of [B, N, T, H], since it concatenates present_key and present_value as present output.
I think here need extra code like
if (attention op) { // can we get operator name from context? Maybe we can use context.outputCount === 2 since MHA and GQA has 3 outputs if present_key are needed.
// insert 2 at the beginning of present shape.
}
There was a problem hiding this comment.
Also need consider another special case for GQA that past and present shares buffers. In that case, the length is max sequence length.
|
with #21782 this one is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.