Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Move setting namespace to build.gradle #21711

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Mobile] Move setting namespace to build.gradle #21711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e81af
updated where the namespace is declared -- moved from Manifest to bui…
carzh Aug 12, 2024
c8fb069
updated package.json according to react-native upgrade helper -- atte…
carzh Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions js/react_native/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ project.xcworkspace
.gradle
local.properties
android.iml
.cxx/
*.keystore
!debug.keystore

# Cocoapods
#
Expand Down
1 change: 1 addition & 0 deletions js/react_native/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def REACT_NATIVE_VERSION = ['node', '--print', "JSON.parse(require('fs').readFil
def REACT_NATIVE_MINOR_VERSION = REACT_NATIVE_VERSION.split("\\.")[1].toInteger()

android {
namespace 'ai.onnxruntime.reactnative'
compileSdkVersion getExtOrIntegerDefault('compileSdkVersion')
buildToolsVersion getExtOrDefault('buildToolsVersion')
defaultConfig {
Expand Down
3 changes: 1 addition & 2 deletions js/react_native/android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="ai.onnxruntime.reactnative">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
</manifest>
6 changes: 3 additions & 3 deletions js/react_native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@
],
"devDependencies": {
"@types/jest": "^27.4.0",
"@types/react": "^18.0.9",
"@types/react": "^18.2.6",
"@types/react-native": "^0.67.7",
"jest": "^27.4.7",
"pod-install": "^0.1.36",
"prettier": "^2.6.2",
"react": "^18.1.0",
"react-native": "^0.69.7",
"react": "^18.2.0",
"react-native": "^0.73.0",
"react-native-builder-bob": "^0.18.2"
},
"peerDependencies": {
Expand Down
Loading