CoreML: Add ML Program ConvTranspose #21416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some limitations to simplify the implementation for now - some limitations due to flaky CoreML output Added support for non-contiguous MLMultiArray output as we see that with some unit tests when the CPU-only flag is not set (e.g. innermost dim has min size of 16 but test output only has 8 values). - support only one non-contiguous dim to keep it simple - manually tested as we don't have a setup that can test objective-c code - test code is in model.mm and can be enabled via ifdef if we need to validate any future changes
|
For reference, here are the bugs I logged for the CoreML behavior with output_shape being inconsistent apple/coremltools#2281 - closed as not an issue with the coremltools python |
skottmckay
commented
Jul 20, 2024
onnxruntime/core/providers/coreml/builders/op_builder_factory.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jul 20, 2024
onnxruntime/core/providers/coreml/builders/impl/convtranspose_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/convtranspose_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/convtranspose_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/convtranspose_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jul 22, 2024
onnxruntime/core/providers/coreml/builders/impl/convtranspose_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
approved these changes
Jul 24, 2024
…rogram_ConvTranspose_PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ML Program ConvTranspose
Added support for non-contiguous MLMultiArray output as we see that with some unit tests when the CPU-only flag is not set (e.g. innermost dim has min size of 16 but test output only has 8 values).
Motivation and Context
Address operator gaps in high priority model.