Update react-native to 0.7x #21122
Update react-native to 0.7x #21122
Conversation
# Conflicts: # tools/python/util/android/android.py
|
This change is surprisingly huge. |
Because those 2 yarn.lock files are generated by npm. I think it might be better generate them during the CI runtime, instead of committing them to the git repo. |
|
@skottmckay , do we need to keep the file there? Nobody can really review the 5 thousand lines of change. Therefore I would think it is a security risk, because we don't exactly know what are brought in there. |
|
This PR requires #17361 |
|
AFAIK the contents of the yarn.lock files don't affect the bits we ship so it may not matter too much. @fs-eire is that correct? This would suggest it's better to checkin yarn.lock for things to be deterministic, but that's countered by our project being a library not an app. https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for Maybe that equates to checking in yarn.lock for the e2e test app and not checking it in for the top-level project. |
|
The file is already excluded in the library (NPM package). Keeping it in the code source helps to make it consistency between all dev environment, which avoid strange errors on CI, for example. |
# Conflicts: # tools/ci_build/github/azure-pipelines/android-x86_64-crosscompile-ci-pipeline.yml
run(sdk_tool_paths.adb, *args)
else:
print("No emulator is running.")
def is_emulator_running(adb_path: str) -> bool:
result = run([adb_path, 'devices'], capture_stdout=True)
output = result.stdout
lines = output.strip().split('\n')
if len(lines) > 1:
for line in lines[1:]:
if "emulator" in line:
return True
return False
# Conflicts: # tools/python/run_adb.py
jchen351
changed the title
Description
Updates react-native to 0.74 and run npm audit fix
Motivation and Context
Trying to fix CGs that associated with npm.
Dependent