-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing COMMAND DOCS #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the binary size compared to main, and if it looks reasonable, we can merge.
1f175e2
to
1c50588
Compare
I've moved the json files to a separate dll that is being loaded (and unloaded) dynamically. The size of Garnet.server.dll is now down to 635KB. Let me know if you like the current solution. The loading & unloading of the assembly would happen at most twice (once for command info init & once for command docs init, on an as-needed basis) and is synchronized as to not cause any issues (Look at RespCommandDataCommon.cs for implementation) Note: I packed and tested the nuget package locally and it works. |
LGTM |
Examples: