Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fhirtimer crashing on shutdown #3834

Closed

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Apr 30, 2024

Description

Fix FhirTimer crashing on shutdown since it throws an exception from an async void.

Related issues

Addresses #3736, AB#117180

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@brendankowitz brendankowitz requested a review from a team as a code owner April 30, 2024 20:20
@brendankowitz brendankowitz added Bug Bug bug bug. Open source This change is only relevant to the OSS code or release. labels Apr 30, 2024
@brendankowitz brendankowitz added this to the S140 milestone Apr 30, 2024
@brendankowitz brendankowitz force-pushed the personal/bkowitz/fhirtimer-crash-onshutdown branch 3 times, most recently from 051f545 to ea547d2 Compare May 1, 2024 05:41
@brendankowitz brendankowitz force-pushed the personal/bkowitz/fhirtimer-crash-onshutdown branch from ea547d2 to e855501 Compare May 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant