Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

221/markdown linter #226

Open
wants to merge 37 commits into
base: dev
Choose a base branch
from
Open

221/markdown linter #226

wants to merge 37 commits into from

Conversation

bderusha
Copy link

No description provided.

pritipath and others added 30 commits November 11, 2022 13:37
@pritipath @bderusha
[M1][#161] Refactor Emissions and Forecast Interfaces
bb3c82d
@JenMadiedo
making location string invariantCulture
c3bd680
@bderusha
BugFix for JSON integration test data
aeac196
@JenMadiedo
[M2][#195] Bug fix for location string localization and JSON integration
d26ee3d 
test data
@pritipath @JenMadiedo
[M1][#161] Refactor Emissions and Forecast Interfaces
cc78b39
@bderusha @JenMadiedo
[M1][#161] Expose Emissions + Forecast data sources to config
7889bc7
@JenMadiedo
Library implementation
4023645
@JenMadiedo
PR comments
e5e8f4e
@JenMadiedo
PR comments
751c437
@vaughanknight
Merge pull request #187 from microsoft/gsf-170/refactor-data-source-i…
20a2dfb 
…nterfaces
@JenMadiedo
[M2][#195] Bug fix for location string localization and JSON integration
2633533 
test data
@bderusha @JenMadiedo
[M1][#161] Expose Emissions + Forecast data sources to config
7adeedb
@vaughanknight
Merge pull request #193 from microsoft/192/stringLocalizationBugFix
f8fb338 
[Bug Fix] Integration Tests + Location string need to be CultureInvariant
@vaughanknight
Merge pull request #188 from microsoft/gsf-170/refactor-data-source-c…
70706a6 
…onfig

Refactor data source config (emissions and forecast)
@vaughanknight
Merge branch 'dev' into 160/libraryRoutes_forecastAndAverage
b13748c
@vaughanknight
Merge pull request #185 from microsoft/160/libraryRoutes_forecastAndA…
3b50928 
…verage

160/library routes forecast and average
@JenMadiedo
[M1][#166] SDK Library Tooling + Packaging
436498e
@JenMadiedo @juzuluag
[M1][#166] SDK Library Tooling + Packaging
e4874b2
@pritipath
[M2][#164] New DataSource Configuration Scheme
40a7d82
@pritipath
deleted dead code paths
6c13246
@holanita
Adding SOGS banner
eb7bad5
@vaughanknight
Merge pull request #191 from microsoft/166/tooling_packaging
ded6d4e 
166/tooling packaging
@vaughanknight
Merge branch 'dev' into 164/update-data-source-config-schema
f13336f
@vaughanknight
Merge pull request #190 from microsoft/164/update-data-source-config-…
bbbf587 
…schema

Update data source config schema
@vaughanknight
Accepated ADR-11 - CD Pipeline for Packages
bab7550 
Accepted.  We can now create issues for each, focus should be on container build first, then we can look at client library priorities.
@bderusha @JenMadiedo
[M2][#171] ElectricityMaps Client implementation
33f0eb8
@bderusha @JenMadiedo
[M2][#171] ElectricityMaps data source implementation
69ca653
@JenMadiedo
Enable GetEmissionsDataAsync, GetBestEmissionsDataAsync and expanded
10c9fac 
 `GetAverageCarbonIntensityAsync` in library
@JenMadiedo
Enable GetForecastByDateAsync in library
b0bdf9d
@JenMadiedo
PR comments
818b468
@codecov-commenter
Copy link

Codecov Report

Merging #226 (a3a7903) into dev (e43b44f) will decrease coverage by 9.43%.
The diff coverage is 68.29%.

❗ Current head a3a7903 differs from pull request most recent head 237f052. Consider uploading reports for the commit 237f052 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #226      +/-   ##
==========================================
- Coverage   86.17%   76.74%   -9.44%     
==========================================
  Files          54       71      +17     
  Lines        1736     2283     +547     
  Branches      193      230      +37     
==========================================
+ Hits         1496     1752     +256     
- Misses        190      468     +278     
- Partials       50       63      +13
Impacted Files Coverage Δ
...yMaps/src/Client/ElectricityMapsClientException.cs 0.00% <0.00%> (ø)
...s/src/Client/ElectricityMapsClientHttpException.cs 0.00% <0.00%> (ø)
...ricityMaps/src/Model/HistoryCarbonIntensityData.cs 0.00% <0.00%> (ø)
...rces/src/Exceptions/LocationConversionException.cs 66.66% <ø> (ø)
...ools.WattTimeClient/src/WattTimeClientException.cs 100.00% <ø> (ø)
....WattTimeClient/src/WattTimeClientHttpException.cs 63.63% <ø> (ø)
...ers/CarbonAwareParametersBaseDtoOperationFilter.cs 0.00% <0.00%> (ø)
...ilters/CarbonAwareParametersBaseDtoSchemaFilter.cs 0.00% <0.00%> (ø)
src/CarbonAware/src/NullEmissionsDataSource.cs 0.00% <0.00%> (ø)
src/CarbonAware/src/NullForecastDataSource.cs 0.00% <0.00%> (ø)
... and 65 more

@bderusha bderusha mentioned this pull request Dec 16, 2022
Open
2 tasks
JenMadiedo pushed a commit that referenced this pull request Jan 10, 2023
@vaughanknight
Merge pull request #226 from microsoft/227/EM-regional-settings-bug
647a234 
ElectricityMaps regional settings bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bderusha @codecov-commenter @pritipath @JenMadiedo @vaughanknight @holanita