Upgrade http(s)-proxy-agent dependent npm packages #22306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
Benjin,
kisantia,
VasuBhog,
Charles-Gagnon,
lucyzhang929,
chlafreniere,
MaddyDev,
llali,
aasimkhan30,
cssuh,
swells and
candiceye
as code owners
aasimkhan30
approved these changes
Mar 12, 2023
Pull Request Test Coverage Report for Build 4407829157
💛 - Coveralls |
Benjin
approved these changes
Mar 13, 2023
llali
approved these changes
Mar 13, 2023
kisantia
approved these changes
Mar 13, 2023
kburtram
approved these changes
Mar 13, 2023
Charles-Gagnon
approved these changes
Mar 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #22227 as the old version of
http-proxy-agentandhttps-proxy-agentpackages seem to conflict with MSAL and cause issues with HTTPS calls (for both MSAL and ADAL).MSAL depends on the updated packages and gets conflicted with the older versions of http packages if present in the package list. VSCode-MSSQL extension also gets impacted with these packages, and a similar issue was resolved there too recently.
Repro is available here: https://github.com/cheenamalhotra/azurewithmsal/tree/failing (ignore lint errors) (Even though it doesn't fail with the same 'certificate is expired' error - it indicates the https-proxy-agent old version package interferes with MSAL calls and is capable of causing issues when communicating with Azure endpoints)
The VSCode-MSSQL extension's RC version (using updated packages only) does not seem impacted by this issue (#22227 (comment))
Notable updates in this PR:
P.S. I did not implement our own HttpClient for proxy integration as of now, as that doesn't seem to have impact on resolving the error. The old npm packages are the root cause of conflicts as also reproduced in repro.