Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-android): Odds and ends #6760

Merged
merged 7 commits into from
Jun 24, 2023
Merged

Conversation

DaveTryon
Copy link
Contributor

@DaveTryon DaveTryon commented Jun 24, 2023

Details

This cleans up some odds and ends from removing Android:

  • Remove C# file types from various exclusion lists (I intentionally left the .vs folder, since it was in the .gitignore file before it was added to .prettierignore
  • Remove some scraps of the old unified building scripts (calls were already removed, but not the guts)
  • Remove configs to debug unified app from inside vscode
  • Remove dependabot policy for electron
Motivation

Android deprecation feature (this is potentially the last PR for this step)

Context

There's a weird reference to playwright from inside main code. It feels like a bug, but since it's not part of the deprecation, I'll put it into a separate PR

Pull request checklist

  • Addresses an existing issue: Android deprecation feature
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@DaveTryon DaveTryon requested a review from a team as a code owner June 24, 2023 00:12
@DaveTryon DaveTryon merged commit 93653c8 into microsoft:main Jun 24, 2023
11 checks passed
@DaveTryon DaveTryon deleted the odds-and-ends branch June 26, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants