feat(remove-android): Docker file cleanup #6759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
commented
Jun 24, 2023
| RUN apt-get update && \ | ||
| apt-get install -y curl apt-transport-https && \ |
There was a problem hiding this comment.
This undoes the Dockerfile changes from #5720, then standardizes the formatting
codeofdusk
approved these changes
Jun 24, 2023
| @@ -14,17 +14,12 @@ USER root | |||
| # | |||
| # We pin nodejs 16.x instead of accepting Playwright's default for consistency with | |||
| # our other build environments. | |||
| # | |||
| # dotnet-sdk-6.0 is required to build mock-adb | |||
| RUN apt-get update && \ | |||
There was a problem hiding this comment.
On modern Debian-based systems:
Suggested change
| RUN apt-get update && \ | |
| RUN apt update && \ |
| curl -fsSL https://packages.microsoft.com/config/ubuntu/20.04/packages-microsoft-prod.deb -o packages-microsoft-prod.deb && \ | ||
| dpkg -i packages-microsoft-prod.deb && \ | ||
| rm packages-microsoft-prod.deb && \ | ||
| apt-get install ca-certificates && \ |
There was a problem hiding this comment.
Suggested change
| apt-get install ca-certificates && \ | |
| apt install ca-certificates && \ |
| curl -fsSL https://packages.microsoft.com/config/ubuntu/20.04/packages-microsoft-prod.deb -o packages-microsoft-prod.deb && \ | ||
| dpkg -i packages-microsoft-prod.deb && \ | ||
| rm packages-microsoft-prod.deb && \ | ||
| apt-get install ca-certificates && \ | ||
| apt-get update && \ |
There was a problem hiding this comment.
Suggested change
| apt-get update && \ | |
| apt update && \ |
| apt-get update && \ | ||
| apt-get install -y curl && \ |
There was a problem hiding this comment.
Suggested change
| apt-get install -y curl && \ | |
| apt install -y curl && \ |
| apt-get update && \ | ||
| apt-get install -y curl && \ | ||
| curl -fsSL https://deb.nodesource.com/setup_16.x | bash - && \ | ||
| apt-get install -y --allow-downgrades nodejs=16.* && \ |
There was a problem hiding this comment.
Suggested change
| apt-get install -y --allow-downgrades nodejs=16.* && \ | |
| apt install -y --allow-downgrades nodejs=16.* && \ |
|
@codeofdusk, I tried replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Simplify our
Dockerfileas follows:Motivation
Part of Android removal feature
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.