Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-android): Remove codec tests #6751

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

DaveTryon
Copy link
Contributor

Details

Deprecating Android support will touch hundreds of files, so we're breaking it up into more manageable units. This PR removes the files under src/tests/miscellaneous/codecs. These tests were added as a guard against accidentally shipping an Electron bundle that included proprietary codecs. Now that we no longer ship Electron, we no longer need the tests.

Motivation

Android deprecation feature

Context

Pull request checklist

  • [n/a] Addresses an existing issue (part of Android deprecation feature)
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@DaveTryon DaveTryon requested a review from a team as a code owner June 22, 2023 22:24
@DaveTryon DaveTryon changed the title feature(remvoe-android): Remove codec tests feature(remove-android): Remove codec tests Jun 22, 2023
@DaveTryon DaveTryon merged commit c32c5dc into microsoft:main Jun 22, 2023
11 checks passed
@DaveTryon DaveTryon deleted the remove-codec-tests branch June 22, 2023 23:48
@DaveTryon DaveTryon changed the title feature(remove-android): Remove codec tests feat(remove-android): Remove codec tests Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants