Only pad initializer types for parameters without annotations and contextual signatures #59975

Andarist · 2024-09-15T21:16:13Z

jakebailey · 2024-09-16T20:07:52Z

typescript-bot · 2024-09-16T20:07:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-16T20:44:57Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-16T20:52:43Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,447k (± 0.02%)}	_{193,038k (± 0.80%)}	_~	_192,392k	_196,196k	_{p=0.298 n=6}
_{Parse Time}	_{1.30s (± 1.34%)}	_{1.30s (± 1.02%)}	_~	_1.29s	_1.32s	_{p=0.454 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.57s (± 0.57%)}	_{9.57s (± 0.36%)}	_~	_9.52s	_9.61s	_{p=0.936 n=6}
_{Emit Time}	_{2.73s (± 0.93%)}	_{2.72s (± 0.83%)}	_~	_2.68s	_2.74s	_{p=0.291 n=6}
_{Total Time}	_{14.32s (± 0.37%)}	_{14.29s (± 0.37%)}	_~	_14.19s	_14.34s	_{p=0.744 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,739k (± 0.00%)}	_{1,222,741k (± 0.00%)}	_~	_1,222,694k	_1,222,786k	_{p=0.936 n=6}
_{Parse Time}	_{6.65s (± 0.49%)}	_{6.69s (± 0.61%)}	_~	_6.64s	_6.76s	_{p=0.091 n=6}
_{Bind Time}	_{1.86s (± 0.48%)}	_{1.86s (± 0.40%)}	_~	_1.85s	_1.87s	_{p=0.798 n=6}
_{Check Time}	_{31.13s (± 0.25%)}	_{31.21s (± 0.37%)}	_~	_31.02s	_31.35s	_{p=0.199 n=6}
_{Emit Time}	_{15.07s (± 0.65%)}	_{15.05s (± 0.39%)}	_~	_14.98s	_15.12s	_{p=0.873 n=6}
_{Total Time}	_{54.71s (± 0.29%)}	_{54.81s (± 0.31%)}	_~	_54.61s	_55.10s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,520,527	_2,520,527	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,974	_935,974	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,350,349k (± 0.00%)}	_{2,350,394k (± 0.00%)}	_{+44k (+ 0.00%)}	_2,350,365k	_2,350,418k	_{p=0.037 n=6}
_{Parse Time}	_{9.27s (± 0.33%)}	_{9.28s (± 0.35%)}	_~	_9.26s	_9.33s	_{p=0.571 n=6}
_{Bind Time}	_{2.14s (± 0.57%)}	_{2.14s (± 0.69%)}	_~	_2.13s	_2.16s	_{p=0.391 n=6}
_{Check Time}	_{72.96s (± 0.52%)}	_{73.34s (± 0.52%)}	_~	_72.62s	_73.77s	_{p=0.173 n=6}
_{Emit Time}	_{0.27s (± 2.98%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.383 n=6}
_{Total Time}	_{84.64s (± 0.43%)}	_{85.05s (± 0.43%)}	_~	_84.35s	_85.44s	_{p=0.149 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,953	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_264,212	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,398,376k (± 0.03%)}	_{2,397,621k (± 0.01%)}	_{-754k (- 0.03%)}	_2,397,327k	_2,397,900k	_{p=0.045 n=6}
_{Parse Time}	_{5.09s (± 0.64%)}	_{5.11s (± 0.86%)}	_~	_5.03s	_5.15s	_{p=0.378 n=6}
_{Bind Time}	_{1.92s (± 0.33%)}	_{1.92s (± 0.79%)}	_~	_1.90s	_1.94s	_{p=0.391 n=6}
_{Check Time}	_{34.74s (± 0.22%)}	_{34.70s (± 0.54%)}	_~	_34.51s	_34.97s	_{p=0.873 n=6}
_{Emit Time}	_{3.03s (± 4.52%)}	_{3.03s (± 2.92%)}	_~	_2.97s	_3.21s	_{p=0.872 n=6}
_{Total Time}	_{44.79s (± 0.36%)}	_{44.77s (± 0.46%)}	_~	_44.58s	_45.09s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,953	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_264,212	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,471,829k (± 0.03%)}	_{2,497,709k (± 2.54%)}	_~	_2,471,133k	_2,627,420k	_{p=0.689 n=6}
_{Parse Time}	_{6.35s (± 0.76%)}	_{6.34s (± 0.66%)}	_~	_6.30s	_6.41s	_{p=0.689 n=6}
_{Bind Time}	_{2.05s (± 0.62%)}	_{2.05s (± 0.65%)}	_~	_2.03s	_2.07s	_{p=0.935 n=6}
_{Check Time}	_{41.34s (± 0.75%)}	_{41.48s (± 0.67%)}	_~	_41.25s	_41.96s	_{p=0.261 n=6}
_{Emit Time}	_{3.69s (± 3.14%)}	_{3.69s (± 3.74%)}	_~	_3.55s	_3.88s	_{p=0.936 n=6}
_{Total Time}	_{53.46s (± 0.70%)}	_{53.57s (± 0.42%)}	_~	_53.27s	_53.95s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,885	_259,886	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,140	_106,139	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,604k (± 0.01%)}	_{435,589k (± 0.01%)}	_~	_435,507k	_435,656k	_{p=0.689 n=6}
_{Parse Time}	_{3.42s (± 0.67%)}	_{3.43s (± 0.50%)}	_~	_3.41s	_3.45s	_{p=0.415 n=6}
_{Bind Time}	_{1.28s (± 1.35%)}	_{1.30s (± 0.76%)}	_{+0.02s (+ 1.56%)}	_1.28s	_1.31s	_{p=0.037 n=6}
_{Check Time}	_{18.14s (± 0.19%)}	_{18.17s (± 0.47%)}	_~	_18.04s	_18.24s	_{p=0.421 n=6}
_{Emit Time}	_{1.50s (± 1.72%)}	_{1.53s (± 1.62%)}	_~	_1.50s	_1.56s	_{p=0.126 n=6}
_{Total Time}	_{24.34s (± 0.12%)}	_{24.43s (± 0.29%)}	_{+0.09s (+ 0.37%)}	_24.31s	_24.50s	_{p=0.045 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,261k (± 0.02%)}	_{370,258k (± 0.01%)}	_~	_370,203k	_370,316k	_{p=0.936 n=6}
_{Parse Time}	_{2.76s (± 0.85%)}	_{2.77s (± 0.99%)}	_~	_2.72s	_2.80s	_{p=1.000 n=6}
_{Bind Time}	_{1.57s (± 0.66%)}	_{1.57s (± 0.77%)}	_~	_1.56s	_1.59s	_{p=0.735 n=6}
_{Check Time}	_{15.74s (± 0.18%)}	_{15.77s (± 0.28%)}	_~	_15.71s	_15.83s	_{p=0.259 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.08s (± 0.23%)}	_{20.11s (± 0.24%)}	_~	_20.05s	_20.17s	_{p=0.470 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,067,616	_3,067,616	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,059,253	_1,059,253	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,173,074k (± 0.00%)}	_{3,173,005k (± 0.00%)}	_~	_3,172,962k	_3,173,069k	_{p=0.066 n=6}
_{Parse Time}	_{13.94s (± 0.29%)}	_{13.95s (± 0.26%)}	_~	_13.92s	_14.02s	_{p=0.747 n=6}
_{Bind Time}	_{4.38s (± 1.98%)}	_{4.38s (± 1.80%)}	_~	_4.34s	_4.54s	_{p=1.000 n=6}
_{Check Time}	_{81.62s (± 0.29%)}	_{81.40s (± 0.32%)}	_~	_80.99s	_81.63s	_{p=0.173 n=6}
_{Emit Time}	_{22.22s (± 0.50%)}	_{22.17s (± 0.46%)}	_~	_22.07s	_22.31s	_{p=0.423 n=6}
_{Total Time}	_{122.16s (± 0.23%)}	_{121.90s (± 0.28%)}	_~	_121.35s	_122.21s	_{p=0.092 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,156	_277,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,946	_112,946	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,997k (± 0.03%)}	_{426,880k (± 0.03%)}	_~	_426,728k	_427,022k	_{p=0.128 n=6}
_{Parse Time}	_{4.90s (± 0.61%)}	_{4.90s (± 0.36%)}	_~	_4.88s	_4.93s	_{p=0.570 n=6}
_{Bind Time}	_{2.15s (± 0.81%)}	_{2.13s (± 0.64%)}	_~	_2.11s	_2.15s	_{p=0.192 n=6}
_{Check Time}	_{21.81s (± 0.61%)}	_{21.71s (± 0.23%)}	_~	_21.63s	_21.76s	_{p=0.173 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.85s (± 0.46%)}	_{28.74s (± 0.21%)}	_~	_28.67s	_28.81s	_{p=0.173 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,582	_531,582	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,676	_181,676	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,742k (± 0.03%)}	_{463,699k (± 0.01%)}	_~	_463,620k	_463,792k	_{p=0.810 n=6}
_{Parse Time}	_{3.13s (± 0.60%)}	_{3.11s (± 0.84%)}	_~	_3.08s	_3.15s	_{p=0.295 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.11s (± 0.37%)}	_~	_1.11s	_1.12s	_{p=0.595 n=6}
_{Check Time}	_{18.20s (± 0.22%)}	_{18.21s (± 0.40%)}	_~	_18.08s	_18.27s	_{p=0.335 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.43s (± 0.17%)}	_{22.44s (± 0.23%)}	_~	_22.35s	_22.50s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-16T21:00:08Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59975/merge:

Everything looks good!

typescript-bot · 2024-09-16T22:05:00Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59975/merge:

Everything looks good!

jakebailey · 2024-09-24T19:21:41Z

@typescript-bot test it

typescript-bot · 2024-09-24T19:21:45Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-24T20:09:37Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-24T20:10:19Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,855k (± 0.94%)}	_{193,860k (± 0.94%)}	_~	_192,651k	_196,251k	_{p=1.000 n=6}
_{Parse Time}	_{1.95s (± 0.60%)}	_{1.95s (± 0.75%)}	_~	_1.94s	_1.98s	_{p=1.000 n=6}
_{Bind Time}	_{1.06s (± 1.10%)}	_{1.06s (± 0.77%)}	_~	_1.05s	_1.07s	_{p=1.000 n=6}
_{Check Time}	_{14.01s (± 0.45%)}	_{13.97s (± 0.34%)}	_~	_13.91s	_14.03s	_{p=0.419 n=6}
_{Emit Time}	_{4.02s (± 4.01%)}	_{4.01s (± 1.53%)}	_~	_3.89s	_4.07s	_{p=0.332 n=6}
_{Total Time}	_{21.05s (± 0.72%)}	_{20.99s (± 0.52%)}	_~	_20.80s	_21.11s	_{p=0.689 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,102	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,738	_410,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,223,989k (± 0.00%)}	_{1,224,019k (± 0.00%)}	_~	_1,223,972k	_1,224,056k	_{p=0.078 n=6}
_{Parse Time}	_{6.60s (± 0.48%)}	_{6.62s (± 0.71%)}	_~	_6.56s	_6.69s	_{p=0.739 n=6}
_{Bind Time}	_{1.87s (± 0.22%)}	_{1.87s (± 0.28%)}	_~	_1.86s	_1.87s	_{p=0.595 n=6}
_{Check Time}	_{31.30s (± 0.25%)}	_{31.27s (± 0.41%)}	_~	_31.08s	_31.40s	_{p=0.810 n=6}
_{Emit Time}	_{15.02s (± 0.46%)}	_{15.04s (± 0.52%)}	_~	_14.98s	_15.17s	_{p=0.810 n=6}
_{Total Time}	_{54.79s (± 0.20%)}	_{54.80s (± 0.22%)}	_~	_54.64s	_54.93s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,651	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,037	_936,037	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,790k (± 0.00%)}	_{2,351,782k (± 0.00%)}	_~	_2,351,744k	_2,351,842k	_{p=0.873 n=6}
_{Parse Time}	_{11.03s (± 0.31%)}	_{11.00s (± 0.30%)}	_~	_10.96s	_11.05s	_{p=0.226 n=6}
_{Bind Time}	_{2.56s (± 0.20%)}	_{2.56s (± 0.40%)}	_~	_2.54s	_2.57s	_{p=0.242 n=6}
_{Check Time}	_{86.81s (± 0.35%)}	_{86.70s (± 0.61%)}	_~	_86.27s	_87.64s	_{p=0.378 n=6}
_{Emit Time}	_{0.33s (± 2.50%)}	_{0.33s (± 2.45%)}	_~	_0.32s	_0.34s	_{p=0.204 n=6}
_{Total Time}	_{100.73s (± 0.32%)}	_{100.59s (± 0.51%)}	_~	_100.16s	_101.50s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,019	_1,250,020	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,952	_264,951	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,464,636k (± 5.96%)}	_{2,464,033k (± 5.94%)}	_~	_2,403,129k	_2,763,190k	_{p=0.298 n=6}
_{Parse Time}	_{7.69s (± 0.93%)}	_{7.64s (± 0.66%)}	_~	_7.58s	_7.72s	_{p=0.173 n=6}
_{Bind Time}	_{2.80s (± 0.79%)}	_{2.81s (± 0.32%)}	_~	_2.80s	_2.82s	_{p=0.934 n=6}
_{Check Time}	_{51.34s (± 1.34%)}	_{51.11s (± 0.75%)}	_~	_50.63s	_51.59s	_{p=0.378 n=6}
_{Emit Time}	_{4.34s (± 2.21%)}	_{4.39s (± 1.54%)}	_~	_4.33s	_4.52s	_{p=0.936 n=6}
_{Total Time}	_{66.19s (± 1.12%)}	_{65.95s (± 0.56%)}	_~	_65.46s	_66.41s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,019	_1,250,020	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,952	_264,951	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,478,650k (± 0.02%)}	_{2,479,554k (± 0.03%)}	_{+904k (+ 0.04%)}	_2,478,444k	_2,480,532k	_{p=0.045 n=6}
_{Parse Time}	_{7.91s (± 0.53%)}	_{7.87s (± 0.47%)}	_~	_7.83s	_7.93s	_{p=0.109 n=6}
_{Bind Time}	_{2.56s (± 0.32%)}	_{2.54s (± 0.60%)}	_~	_2.53s	_2.57s	_{p=0.086 n=6}
_{Check Time}	_{51.74s (± 0.61%)}	_{51.39s (± 0.68%)}	_~	_50.92s	_51.93s	_{p=0.128 n=6}
_{Emit Time}	_{4.37s (± 1.49%)}	_{4.45s (± 4.02%)}	_~	_4.24s	_4.73s	_{p=0.423 n=6}
_{Total Time}	_{66.56s (± 0.60%)}	_{66.27s (± 0.39%)}	_~	_66.01s	_66.72s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,921	_260,922	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,369	_106,368	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,555k (± 0.02%)}	_{436,576k (± 0.03%)}	_~	_436,414k	_436,832k	_{p=1.000 n=6}
_{Parse Time}	_{4.24s (± 0.82%)}	_{4.27s (± 0.64%)}	_~	_4.23s	_4.29s	_{p=0.191 n=6}
_{Bind Time}	_{1.60s (± 0.64%)}	_{1.60s (± 0.85%)}	_~	_1.57s	_1.61s	_{p=0.591 n=6}
_{Check Time}	_{22.47s (± 0.33%)}	_{22.42s (± 0.35%)}	_~	_22.31s	_22.51s	_{p=0.228 n=6}
_{Emit Time}	_{1.86s (± 1.16%)}	_{1.86s (± 1.38%)}	_~	_1.82s	_1.90s	_{p=0.803 n=6}
_{Total Time}	_{30.18s (± 0.28%)}	_{30.14s (± 0.31%)}	_~	_29.97s	_30.25s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,882k (± 0.04%)}	_{370,872k (± 0.02%)}	_~	_370,784k	_370,931k	_{p=0.630 n=6}
_{Parse Time}	_{3.43s (± 0.57%)}	_{3.42s (± 0.57%)}	_~	_3.41s	_3.46s	_{p=0.418 n=6}
_{Bind Time}	_{1.92s (± 0.99%)}	_{1.94s (± 1.51%)}	_~	_1.92s	_1.99s	_{p=0.220 n=6}
_{Check Time}	_{19.43s (± 0.36%)}	_{19.49s (± 0.28%)}	_~	_19.43s	_19.57s	_{p=0.229 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.78s (± 0.27%)}	_{24.86s (± 0.23%)}	_{+0.08s (+ 0.32%)}	_24.78s	_24.92s	_{p=0.045 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,099,752	_3,099,752	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,068,967	_1,068,967	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,196,800k (± 0.00%)}	_{3,196,763k (± 0.00%)}	_~	_3,196,713k	_3,196,826k	_{p=0.230 n=6}
_{Parse Time}	_{13.94s (± 0.32%)}	_{13.96s (± 0.40%)}	_~	_13.90s	_14.06s	_{p=1.000 n=6}
_{Bind Time}	_{4.45s (± 2.44%)}	_{4.38s (± 0.53%)}	_~	_4.35s	_4.42s	_{p=0.167 n=6}
_{Check Time}	_{82.30s (± 0.41%)}	_{82.45s (± 0.47%)}	_~	_81.97s	_83.05s	_{p=0.575 n=6}
_{Emit Time}	_{22.39s (± 0.25%)}	_{22.45s (± 0.31%)}	_~	_22.37s	_22.54s	_{p=0.199 n=6}
_{Total Time}	_{123.07s (± 0.32%)}	_{123.24s (± 0.31%)}	_~	_122.71s	_123.75s	_{p=0.521 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_278,920	_278,920	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,837	_113,837	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,415k (± 0.02%)}	_{428,373k (± 0.02%)}	_~	_428,278k	_428,512k	_{p=0.471 n=6}
_{Parse Time}	_{4.89s (± 0.29%)}	_{4.90s (± 0.71%)}	_~	_4.84s	_4.93s	_{p=0.331 n=6}
_{Bind Time}	_{2.13s (± 1.06%)}	_{2.13s (± 1.17%)}	_~	_2.09s	_2.16s	_{p=1.000 n=6}
_{Check Time}	_{21.84s (± 0.51%)}	_{21.82s (± 0.47%)}	_~	_21.64s	_21.95s	_{p=0.809 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.85s (± 0.36%)}	_{28.85s (± 0.39%)}	_~	_28.69s	_29.02s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,292	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,493k (± 0.01%)}	_{483,511k (± 0.01%)}	_~	_483,479k	_483,552k	_{p=0.689 n=6}
_{Parse Time}	_{4.01s (± 0.20%)}	_{4.01s (± 0.27%)}	_~	_4.00s	_4.03s	_{p=0.666 n=6}
_{Bind Time}	_{1.42s (± 0.82%)}	_{1.42s (± 1.33%)}	_~	_1.40s	_1.45s	_{p=1.000 n=6}
_{Check Time}	_{22.88s (± 0.33%)}	_{22.81s (± 0.39%)}	_~	_22.66s	_22.92s	_{p=0.227 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.31s (± 0.25%)}	_{28.24s (± 0.35%)}	_~	_28.10s	_28.39s	_{p=0.230 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-24T20:26:29Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59975/merge:

Everything looks good!

typescript-bot · 2024-09-24T21:41:34Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59975/merge:

Everything looks good!

jakebailey · 2024-09-25T18:07:11Z

Maybe I'm misunderstanding it, but isn't this sorta kinda a revert of #59183 but only in the parameter case? Is this too targeted? Or am I misunderstanding?

I do want to make progress on this and #59924 to fix the regressions, though.

jakebailey · 2024-09-25T18:36:57Z

@typescript-bot pack this

typescript-bot · 2024-09-25T18:37:01Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-09-25T18:39:12Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163707/artifacts?artifactName=tgz&fileId=47229EAAA24F14EBCB7C609277AE51963A02A909545BDE010EE6663B7DF70E1802&fileName=/typescript-5.7.0-insiders.20240925.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Andarist · 2024-09-25T18:53:00Z

Maybe I'm misunderstanding it, but isn't this sorta kinda a revert of #59183 but only in the parameter case? Is this too targeted? Or am I misunderstanding?

It's not a revert. Previously object literal types were contextually-typed by their corresponding patterns.

So in a situation like this:

function test({ a = 1 } = {}) {}

The type of this {} ended up to be { a?: number }. Since #59183 that's no longer the case - its type stays as {}. This fact/difference isn't particularly observable to the user but the signature computed based on it can be quite different. The signature is meant to be (_: { a?: number }) => void.

Since the type of the initializer expressions changed in #59183, Anders introduced "object padding" for those initializer types - a way to go from the initializer type to a parameter type using the available binding pattern information. Such mechanism was already used for tuple types. So this was a way to unify the algorithm for both object and array patterns in parameter positions.

That new object padding introduced regressions but only because it didn't cover some cases (see #59924 ) and because it's too eager in some other cases (like this one here).

TLDR: it's not a revert, it's just an extension of those changes

Only pad initializer types for parameters without annotations

b836d23

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 15, 2024

Andarist mentioned this pull request Sep 15, 2024

Binding element incorrectly reported as having any type in JS with JSDoc starting with 5.6.2 #59936

Closed

burtek mentioned this pull request Sep 15, 2024

chore(deps): update dependency typescript to ~5.6.0 (master) burtek/eslint-config#154

Merged

1 task

dont pad contextually-typed parameters either

909bac2

Andarist changed the title ~~Only pad initializer types for parameters without annotations~~ Only pad initializer types for parameters without annotations and contextual signatures Sep 17, 2024

jakebailey requested a review from ahejlsberg September 24, 2024 22:46

ahejlsberg mentioned this pull request Sep 27, 2024

Don't issue implicit any when obtaining the implied type for a binding pattern #60083

Merged

Andarist closed this Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only pad initializer types for parameters without annotations and contextual signatures #59975

Only pad initializer types for parameters without annotations and contextual signatures #59975

Andarist commented Sep 15, 2024

jakebailey commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 •

edited

Loading

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

tsc

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

jakebailey commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

tsc

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

jakebailey commented Sep 25, 2024

jakebailey commented Sep 25, 2024

typescript-bot commented Sep 25, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024 •

edited

Loading

Andarist commented Sep 25, 2024

Only pad initializer types for parameters without annotations and contextual signatures #59975

Only pad initializer types for parameters without annotations and contextual signatures #59975

Conversation

Andarist commented Sep 15, 2024

jakebailey commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 • edited Loading

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

tsc

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

jakebailey commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 • edited Loading

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

tsc

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

jakebailey commented Sep 25, 2024

jakebailey commented Sep 25, 2024

typescript-bot commented Sep 25, 2024 • edited Loading

typescript-bot commented Sep 25, 2024 • edited Loading

Andarist commented Sep 25, 2024

typescript-bot commented Sep 16, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024 •

edited

Loading