-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Conversation
Update User model update "any" types to more precise
Just figuring out how everything works, sorry if it's rough around the edges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove commented code like:
// [provider: string]: any;
(either uncomment if temporary changes or remove completetly , or update comment with specific information
Remove direct use of genericExpressMethod
, using Request/Response/NextFunction should work
no-explicit-any: warning, no-inferrable-types: warning except for parameters update (remove) "any" types
Can a ask for a bit of advice, please: what if I want to push to my fork branch, but don't want to include these commits to this pull request? Or I should just wait for this PR to be closed and in the meantime use a different branch? |
Up to you, you've even used very new |
created new PR from separate branch #232 |
Consolidate repeating types, augment express.Request with User model (copies #227 )
Update User model:
TypeScript-Node-Starter/src/controllers/user.ts
Line 217 in 1409fd7