This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Scene Understanding improvements #103
Open
shukenmg
wants to merge
1
commit into
microsoft:5.1
Choose a base branch
from
shukenmg:SU_Dev
base: 5.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shukenmg please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds these features:
Spatial Mapping can now use
XR_SCENE_COMPUTE_CONSISTENCY_SNAPSHOT_INCOMPLETE_FAST_MSFT
for mesh data.This results in a smoother and more complete mesh, trading off speed for quality.
Fixes Unnecessary Plane Updates when using spatial mapping. #102
Fixes Support LOD and better spatial mesh quality in Scene Understanding #101
Support for LOD, defined in https://registry.khronos.org/OpenXR/specs/1.0/man/html/XrMeshComputeLodMSFT.html
Changed
SpatialMeshingVolumeSize
from being a platform limited variable to being available anywhere, this is to support Holographic Remoting. Also, renamed it toSceneUnderstandingVolumeRadius
New config variables to control the features above
ShouldDoSceneUnderstandingHighQualityMeshing
controls the spatial mapping consistencySceneUnderstandingVolumeRadius
renamed and relocated fromSpatialMeshingVolumeSize
SceneUnderstandingMeshingLOD
this is a interger based value corresponding to theXrMeshComputeLodMSFT
definition.Also, there is this issue where the meshes/planes won't be updated the first time because its
UnderlyingMesh
wasn't ready, this PR fixes this by allocating new meshes/planes duringProcessSceneUpdate
so that itsUnderlyingMesh
will be ready for the mesh/extents data update.